You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2014/07/23 21:30:57 UTC
git commit: updated refs/heads/master to b8112ac
Repository: cloudstack
Updated Branches:
refs/heads/master 44be17648 -> b8112ac79
highlevel 'unit'-test for refactoring of (Vpc)VirtualNetworkApplianceManagerImpl
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/b8112ac7
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/b8112ac7
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/b8112ac7
Branch: refs/heads/master
Commit: b8112ac79e6205573b15898f83192adf4df74626
Parents: 44be176
Author: Daan Hoogland <da...@onecht.net>
Authored: Wed Jul 23 21:30:21 2014 +0200
Committer: Daan Hoogland <da...@onecht.net>
Committed: Wed Jul 23 21:30:21 2014 +0200
----------------------------------------------------------------------
.../element/VirtualRouterElementTest.java | 278 +++++++++++++++++++
1 file changed, 278 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/b8112ac7/server/test/com/cloud/network/element/VirtualRouterElementTest.java
----------------------------------------------------------------------
diff --git a/server/test/com/cloud/network/element/VirtualRouterElementTest.java b/server/test/com/cloud/network/element/VirtualRouterElementTest.java
new file mode 100644
index 0000000..dcd4691
--- /dev/null
+++ b/server/test/com/cloud/network/element/VirtualRouterElementTest.java
@@ -0,0 +1,278 @@
+package com.cloud.network.element;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyBoolean;
+import static org.mockito.Matchers.anyLong;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.when;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.cloud.cluster.dao.ManagementServerHostDao;
+import com.cloud.configuration.ConfigurationManager;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenter.NetworkType;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.HostPodDao;
+import com.cloud.dc.dao.VlanDao;
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.host.dao.HostDao;
+import com.cloud.hypervisor.Hypervisor.HypervisorType;
+import com.cloud.network.Network;
+import com.cloud.network.Network.Service;
+import com.cloud.network.Networks.TrafficType;
+import com.cloud.network.NetworkModel;
+import com.cloud.network.NetworkModelImpl;
+import com.cloud.network.VirtualRouterProvider.Type;
+import com.cloud.network.dao.FirewallRulesDao;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.LoadBalancerDao;
+import com.cloud.network.dao.LoadBalancerVMMapDao;
+import com.cloud.network.dao.MonitoringServiceDao;
+import com.cloud.network.dao.NetworkDao;
+import com.cloud.network.dao.NetworkVO;
+import com.cloud.network.dao.OpRouterMonitorServiceDao;
+import com.cloud.network.dao.OvsProviderDao;
+import com.cloud.network.dao.PhysicalNetworkServiceProviderDao;
+import com.cloud.network.dao.PhysicalNetworkServiceProviderVO;
+import com.cloud.network.dao.RemoteAccessVpnDao;
+import com.cloud.network.dao.Site2SiteCustomerGatewayDao;
+import com.cloud.network.dao.Site2SiteVpnConnectionDao;
+import com.cloud.network.dao.Site2SiteVpnGatewayDao;
+import com.cloud.network.dao.UserIpv6AddressDao;
+import com.cloud.network.dao.VirtualRouterProviderDao;
+import com.cloud.network.dao.VpnUserDao;
+import com.cloud.network.router.VirtualRouter.RedundantState;
+import com.cloud.network.router.VpcVirtualNetworkApplianceManagerImpl;
+import com.cloud.network.rules.dao.PortForwardingRulesDao;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.resource.ResourceManager;
+import com.cloud.service.ServiceOfferingVO;
+import com.cloud.service.dao.ServiceOfferingDao;
+import com.cloud.storage.Storage.ProvisioningType;
+import com.cloud.storage.VMTemplateVO;
+import com.cloud.storage.dao.GuestOSDao;
+import com.cloud.storage.dao.VMTemplateDao;
+import com.cloud.storage.dao.VolumeDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountManager;
+import com.cloud.user.AccountVO;
+import com.cloud.user.dao.UserDao;
+import com.cloud.user.dao.UserStatisticsDao;
+import com.cloud.user.dao.UserStatsLogDao;
+import com.cloud.vm.DomainRouterVO;
+import com.cloud.vm.NicProfile;
+import com.cloud.vm.ReservationContext;
+import com.cloud.vm.ReservationContextImpl;
+import com.cloud.vm.UserVmManager;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineManager;
+import com.cloud.vm.VirtualMachineProfile;
+import com.cloud.vm.dao.DomainRouterDao;
+import com.cloud.vm.dao.NicDao;
+import com.cloud.vm.dao.NicIpAliasDao;
+import com.cloud.vm.dao.UserVmDao;
+import com.cloud.vm.dao.UserVmDetailsDao;
+import com.cloud.vm.dao.VMInstanceDao;
+
+@RunWith(MockitoJUnitRunner.class)
+public class VirtualRouterElementTest {
+ @Mock private ClusterDao _clusterDao;
+ @Mock private ConfigurationDao _configDao;
+ @Mock private DataCenterDao _dcDao;
+ @Mock private GuestOSDao _guestOSDao;
+ @Mock private HostDao _hostDao;
+ @Mock private IPAddressDao _ipAddressDao;
+ @Mock private UserIpv6AddressDao _ipv6Dao;
+ @Mock private LoadBalancerDao _loadBalancerDao;
+ @Mock private LoadBalancerVMMapDao _loadBalancerVMMapDao;
+ @Mock private MonitoringServiceDao _monitorServiceDao;
+ @Mock private ManagementServerHostDao _msHostDao;
+ @Mock private NetworkDao _networkDao;
+ @Mock private NetworkOfferingDao _networkOfferingDao;
+ @Mock private NicDao _nicDao;
+ @Mock private NicIpAliasDao _nicIpAliasDao;
+ @Mock private OpRouterMonitorServiceDao _opRouterMonitorServiceDao;
+ @Mock private PortForwardingRulesDao _pfRulesDao;
+ @Mock private PhysicalNetworkServiceProviderDao _physicalProviderDao;
+ @Mock private HostPodDao _podDao;
+ @Mock private DomainRouterDao _routerDao;
+ @Mock private FirewallRulesDao _rulesDao;
+ @Mock private Site2SiteCustomerGatewayDao _s2sCustomerGatewayDao;
+ @Mock private Site2SiteVpnConnectionDao _s2sVpnConnectionDao;
+ @Mock private Site2SiteVpnGatewayDao _s2sVpnGatewayDao;
+ @Mock private ServiceOfferingDao _serviceOfferingDao;
+ @Mock private VMTemplateDao _templateDao;
+ @Mock private UserDao _userDao;
+ @Mock private UserStatisticsDao _userStatsDao;
+ @Mock private UserStatsLogDao _userStatsLogDao;
+ @Mock private UserVmDao _userVmDao;
+ @Mock private VlanDao _vlanDao;
+ @Mock private VMInstanceDao _vmDao;
+ @Mock private UserVmDetailsDao _vmDetailsDao;
+ @Mock private VolumeDao _volumeDao;
+ @Mock private RemoteAccessVpnDao _vpnDao;
+ @Mock private VpnUserDao _vpnUsersDao;
+ @Mock private VirtualRouterProviderDao _vrProviderDao;
+ @Mock private LoadBalancerDao _lbDao;
+ @Mock private NetworkDao _networksDao;
+ @Mock private OvsProviderDao _ovsProviderDao;
+
+ @Mock private ServiceOfferingVO _offering;
+ @Mock private NetworkModelImpl _networkModel;
+
+ @Mock private AccountManager _accountMgr;
+ @Mock private ConfigurationManager _configMgr;
+ @Mock private NetworkModel _networkMdl;
+ @Mock private NetworkOrchestrationService _networkMgr;
+ @Mock private ResourceManager _resourceMgr;
+ @Mock private UserVmManager _userVmMgr;
+ @Mock private VirtualMachineManager _itMgr;
+
+ @InjectMocks
+ private VpcVirtualNetworkApplianceManagerImpl _routerMgr ;
+
+ @InjectMocks
+ private VirtualRouterElement virtualRouterElement;
+
+ DataCenter testDataCenter = new DataCenterVO(/* id */ 1L,
+ "name",
+ "description",
+ "dns1",
+ /* dns2 */ null,
+ /* dns3 */ null,
+ /* dns4 */ null,
+ "cidr",
+ "domain",
+ /*domainid */ null,
+ NetworkType.Advanced,
+ "zoneToken",
+ "domainSuffix");
+ DeployDestination testDestination = new DeployDestination(testDataCenter,null,null,null);
+ ReservationContext testContext = new ReservationContextImpl(null, null, null);
+ NetworkVO testNetwork = new NetworkVO();
+ NicProfile testNicProfile = new NicProfile();
+ NetworkOfferingVO testOffering = new NetworkOfferingVO();
+ @Mock VirtualMachineProfile testVMProfile;
+
+ @Test
+ public void testImplementInAdvancedZoneOnXenServer() throws Exception {
+ virtualRouterElement._routerMgr = _routerMgr;
+ mockDAOs(testNetwork, testOffering);
+ mockMgrs();
+
+ boolean done = virtualRouterElement.implement(testNetwork, testOffering, testDestination, testContext);
+ assertTrue("no cigar for network daddy",done);
+ }
+
+ @Test
+ public void testPrepare() {
+ virtualRouterElement._routerMgr = _routerMgr;
+ mockDAOs(testNetwork,testOffering);
+ mockMgrs();
+
+ boolean done = false;
+ try {
+ done = virtualRouterElement.prepare(testNetwork, testNicProfile, testVMProfile, testDestination, testContext);
+ } catch (ConcurrentOperationException | InsufficientCapacityException | ResourceUnavailableException e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
+ }
+ assertTrue("can not even start to create a router", done);
+
+ }
+
+ /**
+ * @param networks
+ * @param offerings
+ * @throws ConcurrentOperationException
+ */
+ private void mockMgrs() throws ConcurrentOperationException {
+ Service service = Service.Connectivity;
+ testNetwork.setState(Network.State.Implementing);
+ testNetwork.setTrafficType(TrafficType.Guest);
+ when(_networkMdl.isProviderEnabledInPhysicalNetwork(0L, "VirtualRouter")).thenReturn(true);
+ when(_networkMdl.isProviderSupportServiceInNetwork(testNetwork.getId(), service, Network.Provider.VirtualRouter)).thenReturn(true);
+ when(_networkMdl.isProviderForNetwork(Network.Provider.VirtualRouter, 0L)).thenReturn(true);
+ when(testVMProfile.getType()).thenReturn(VirtualMachine.Type.User);
+ when(testVMProfile.getHypervisorType()).thenReturn(HypervisorType.XenServer);
+ List<NetworkVO> networks = new ArrayList<NetworkVO>(1);
+ networks.add(testNetwork);
+ List<NetworkOfferingVO> offerings = new ArrayList<NetworkOfferingVO>(1);
+ offerings.add(testOffering);
+ doReturn(offerings).when(_networkModel).getSystemAccountNetworkOfferings(NetworkOffering.SystemControlNetwork);
+ doReturn(networks).when(_networkMgr).setupNetwork(any(Account.class), any(NetworkOffering.class), any(DeploymentPlan.class), any(String.class), any(String.class), anyBoolean());
+ // being anti-social and testing my own case first
+ doReturn(HypervisorType.XenServer).when(_resourceMgr).getDefaultHypervisor(anyLong());
+ doReturn(new AccountVO()).when(_accountMgr).getAccount(testNetwork.getAccountId());
+ }
+
+ /**
+ * @param network
+ */
+ private void mockDAOs(NetworkVO network, NetworkOfferingVO offering) {
+ when(_networkDao.acquireInLockTable(network.getId(), NetworkOrchestrationService.NetworkLockTimeout.value())).thenReturn(network);
+ when(_networksDao.acquireInLockTable(network.getId(), NetworkOrchestrationService.NetworkLockTimeout.value())).thenReturn(network);
+ when(_physicalProviderDao.findByServiceProvider(0L, "VirtualRouter")).thenReturn(new PhysicalNetworkServiceProviderVO());
+ when(_vrProviderDao.findByNspIdAndType(0L, Type.VirtualRouter)).thenReturn(new VirtualRouterProviderVO());
+ when(_networkOfferingDao.findById(0L)).thenReturn(offering);
+ // watchit: (in this test) there can be only one
+ when(_routerDao.getNextInSequence(Long.class, "id")).thenReturn(0L);
+ ServiceOfferingVO svcoff = new ServiceOfferingVO("name",
+ /* cpu */ 1,
+ /* ramsize */ 1024*1024,
+ /* (clock?)speed */ 1024*1024*1024,
+ /* rateMbps */ 1,
+ /* multicastRateMbps */ 0,
+ /* offerHA */ false,
+ "displayText",
+ ProvisioningType.THIN,
+ /* useLocalStorage */ false,
+ /* recreatable */ false,
+ "tags",
+ /* systemUse */ false,
+ VirtualMachine.Type.DomainRouter,
+ /* defaultUse */ false);
+ when(_serviceOfferingDao.findById(0L)).thenReturn(svcoff);
+ DomainRouterVO router = new DomainRouterVO(/* id */ 1L,
+ /* serviceOfferingId */ 1L,
+ /* elementId */ 0L,
+ "name",
+ /* templateId */0L,
+ HypervisorType.XenServer,
+ /* guestOSId */ 0L,
+ /* domainId */ 0L,
+ /* accountId */ 1L,
+ /* isRedundantRouter */ false,
+ /* priority */ 0,
+ /* isPriorityBumpUp */ false,
+ RedundantState.UNKNOWN,
+ /* haEnabled */ false,
+ /* stopPending */ false,
+ /* vpcId */ null);
+
+ when(_routerDao.getNextInSequence(Long.class, "id")).thenReturn(1L);
+ when(_templateDao.findRoutingTemplate(HypervisorType.XenServer, "SystemVM Template (XenServer)")).thenReturn(new VMTemplateVO());
+ when(_routerDao.persist(any(DomainRouterVO.class))).thenReturn(router);
+ when(_routerDao.findById(router.getId())).thenReturn(router);
+ }
+
+}