You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/05/16 00:31:45 UTC

[jira] Updated: (HADOOP-5854) findbugs : fix "Inconsistent Synchronization" warnings in hdfs

     [ https://issues.apache.org/jira/browse/HADOOP-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5854:
---------------------------------

    Attachment: HADOOP-5854.patch

patch attached. Fixes are of two types :
  
 * to synchronize properly (or explicitly so that findbugs recognizes)
 * to declare a variable volatile : these warnings are known and are justified in various other jiras. Usually either the current usage is fine or fixing it is not worth the effort.

> findbugs : fix "Inconsistent Synchronization" warnings in hdfs 
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5854
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: HADOOP-5854.patch
>
>
> This jira fixes the following findbugs warnings :
> * 	Inconsistent synchronization of org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closed; locked 75% of time
> * 	Inconsistent synchronization of org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.persistBlocks; locked 66% of time
> * 	Inconsistent synchronization of org.apache.hadoop.hdfs.server.common.UpgradeManager.currentUpgrades; locked 61% of time
> * 	Inconsistent synchronization of org.apache.hadoop.hdfs.server.common.UpgradeManager.upgradeState; locked 75% of time
> *	Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSDirectory.ready; locked 50% of time
> * 	Inconsistent synchronization of org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.verificationLog; locked 45% of time
> *      Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSNamesystem.safeMode; locked 48% of time
> *	Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSNamesystem$SafeModeInfo.extension; locked 80% of time
> *      Inconsistent synchronization of org.apache.hadoop.io.SequenceFile$Reader.sync; locked 85% of time

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.