You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/02/19 20:41:37 UTC

Review Request 43780: SQOOP-2847 Sqoop --incremental + missing parent --target-dir reports success with no data

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43780/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2847
    https://issues.apache.org/jira/browse/SQOOP-2847


Repository: sqoop-trunk


Description
-------

The problem happened because we have fs.rename() call without checking return value. I've added checks for return value and also  added code that generates parent directories if they do not exists already.


Diffs
-----

  src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 
  src/test/com/cloudera/sqoop/TestIncrementalImport.java d28a187 

Diff: https://reviews.apache.org/r/43780/diff/


Testing
-------

Added unit test and verified on real cluster.


Thanks,

Jarek Cecho