You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyifan279 (via GitHub)" <gi...@apache.org> on 2024/05/12 15:41:09 UTC
[PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
zhouyifan279 opened a new pull request, #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711
## What changes were proposed in this pull request?
A follow-up of PR #5544 to fix min_by/max_by result mismatch when RDD partition num > 1.
## How was this patch tested?
Modified test case "VeloxAggregateFunctionsSuite - min_by/max_by"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2108637796
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_05_13_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_05_11_2024_4899ea5c8_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>36.42</font></td>
<td><font color=#6F9915>33.75</font></td>
<td><font color=#6F9915>-2.676</font></td>
<td><font color=#6F9915>92.65%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>23.70</font></td>
<td><font color=#6F9915>23.55</font></td>
<td><font color=#6F9915>-0.142</font></td>
<td><font color=#6F9915>99.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>36.61</font></td>
<td><font color=#F92663>38.11</font></td>
<td><font color=#F92663>1.498</font></td>
<td><font color=#F92663>104.09%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>37.83</font></td>
<td><font color=#6F9915>37.13</font></td>
<td><font color=#6F9915>-0.695</font></td>
<td><font color=#6F9915>98.16%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>70.62</font></td>
<td><font color=#6F9915>68.76</font></td>
<td><font color=#6F9915>-1.853</font></td>
<td><font color=#6F9915>97.38%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.47</font></td>
<td><font color=#F92663>7.57</font></td>
<td><font color=#F92663>0.103</font></td>
<td><font color=#F92663>101.38%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>85.08</font></td>
<td><font color=#6F9915>82.51</font></td>
<td><font color=#6F9915>-2.566</font></td>
<td><font color=#6F9915>96.98%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>84.30</font></td>
<td><font color=#6F9915>82.99</font></td>
<td><font color=#6F9915>-1.311</font></td>
<td><font color=#6F9915>98.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>121.00</font></td>
<td><font color=#6F9915>120.65</font></td>
<td><font color=#6F9915>-0.349</font></td>
<td><font color=#6F9915>99.71%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.37</font></td>
<td><font color=#6F9915>45.36</font></td>
<td><font color=#6F9915>-0.002</font></td>
<td><font color=#6F9915>100.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>19.49</font></td>
<td><font color=#F92663>20.15</font></td>
<td><font color=#F92663>0.660</font></td>
<td><font color=#F92663>103.38%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>26.52</font></td>
<td><font color=#F92663>30.08</font></td>
<td><font color=#F92663>3.562</font></td>
<td><font color=#F92663>113.43%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>55.08</font></td>
<td><font color=#6F9915>53.02</font></td>
<td><font color=#6F9915>-2.058</font></td>
<td><font color=#6F9915>96.26%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>21.53</font></td>
<td><font color=#6F9915>20.74</font></td>
<td><font color=#6F9915>-0.789</font></td>
<td><font color=#6F9915>96.34%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>29.02</font></td>
<td><font color=#F92663>30.86</font></td>
<td><font color=#F92663>1.840</font></td>
<td><font color=#F92663>106.34%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>14.00</font></td>
<td><font color=#6F9915>13.92</font></td>
<td><font color=#6F9915>-0.083</font></td>
<td><font color=#6F9915>99.41%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>103.62</font></td>
<td><font color=#6F9915>101.26</font></td>
<td><font color=#6F9915>-2.360</font></td>
<td><font color=#6F9915>97.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>146.24</font></td>
<td><font color=#F92663>146.46</font></td>
<td><font color=#F92663>0.225</font></td>
<td><font color=#F92663>100.15%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.35</font></td>
<td><font color=#F92663>15.45</font></td>
<td><font color=#F92663>2.101</font></td>
<td><font color=#F92663>115.73%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>29.06</font></td>
<td><font color=#6F9915>26.42</font></td>
<td><font color=#6F9915>-2.643</font></td>
<td><font color=#6F9915>90.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>282.54</font></td>
<td><font color=#F92663>284.10</font></td>
<td><font color=#F92663>1.553</font></td>
<td><font color=#F92663>100.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.61</font></td>
<td><font color=#F92663>16.40</font></td>
<td><font color=#F92663>1.786</font></td>
<td><font color=#F92663>112.23%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1303.44</font></td>
<td><font color=#6F9915>1299.24</font></td>
<td><font color=#6F9915>-4.200</font></td>
<td><font color=#6F9915>99.68%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106586947
@yma11 Did you reproduced the problem I mentioned [here](https://github.com/apache/incubator-gluten/pull/5544#issuecomment-2106285804) based on the master gluten branch?
That is what I'm trying to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2107249584
@yma11 CI `run-spark-test-spark34`'s failure seems irrelevant with this PR. Can you rerun it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106294546
https://github.com/apache/incubator-gluten/issues/4652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106594968
> I think I used to test the `"spark.default.parallelism", "2"` in previous fix and it worked. So what's the root cause of the failure as you tested? which part is the corresponding fix?
I guess you didn't reproduce the problem because there was only 1 file under test table dir.
In that case, only 1 task existed in the Spark aggregation stage and the result was correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "yma11 (via GitHub)" <gi...@apache.org>.
yma11 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106811681
> > > @yma11 Did you reproduced the problem I mentioned above based on the master gluten branch? That is what I'm trying to fix.
> >
> >
> > I mean which part of your code changes in this PR is the fix? Seems only some code refactor?
>
> Before this PR, `RowConstructorWithAllNullCallToSpecialForm.constructSpecialForm`(the one defined in `RowConstructorWithAllNull.h`) was not called when function name was `row_constructor_with_all_null`. I think it was related to C++ overload/override mechanism.
>
> In this PR, I take function name as a member of `RowConstructorWithNullCallToSpecialForm` to avoid the overload/override issues and fix the result mismatch.
That's interesting. Actually, I verified the previous code using real workload but with single parquet file so may not trigger your scenario. Thanks for your fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "yma11 (via GitHub)" <gi...@apache.org>.
yma11 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106466664
I think I used to test the `"spark.default.parallelism", "2"` in previous fix and it worked. So what's the root cause of the failure as you tested? which part is the corresponding fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you merged PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2108529275
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_05_13_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_05_11_2024_4899ea5c8_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>14.93</font></td>
<td><font color=#6F9915>14.75</font></td>
<td><font color=#6F9915>-0.181</font></td>
<td><font color=#6F9915>98.79%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>13.61</font></td>
<td><font color=#F92663>17.57</font></td>
<td><font color=#F92663>3.956</font></td>
<td><font color=#F92663>129.06%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>4.67</font></td>
<td><font color=#6F9915>4.36</font></td>
<td><font color=#6F9915>-0.310</font></td>
<td><font color=#6F9915>93.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>63.56</font></td>
<td><font color=#6F9915>61.96</font></td>
<td><font color=#6F9915>-1.597</font></td>
<td><font color=#6F9915>97.49%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>6.45</font></td>
<td><font color=#F92663>7.89</font></td>
<td><font color=#F92663>1.446</font></td>
<td><font color=#F92663>122.43%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>4.14</font></td>
<td><font color=#F92663>4.31</font></td>
<td><font color=#F92663>0.169</font></td>
<td><font color=#F92663>104.09%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>5.78</font></td>
<td><font color=#F92663>5.89</font></td>
<td><font color=#F92663>0.115</font></td>
<td><font color=#F92663>101.99%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>3.23</font></td>
<td><font color=#6F9915>3.14</font></td>
<td><font color=#6F9915>-0.089</font></td>
<td><font color=#6F9915>97.24%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>20.14</font></td>
<td><font color=#6F9915>17.64</font></td>
<td><font color=#6F9915>-2.506</font></td>
<td><font color=#6F9915>87.56%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>10.40</font></td>
<td><font color=#6F9915>9.35</font></td>
<td><font color=#6F9915>-1.052</font></td>
<td><font color=#6F9915>89.89%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>36.53</font></td>
<td><font color=#F92663>40.33</font></td>
<td><font color=#F92663>3.795</font></td>
<td><font color=#F92663>110.39%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>1.37</font></td>
<td><font color=#F92663>2.81</font></td>
<td><font color=#F92663>1.438</font></td>
<td><font color=#F92663>205.12%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>5.67</font></td>
<td><font color=#F92663>5.93</font></td>
<td><font color=#F92663>0.258</font></td>
<td><font color=#F92663>104.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14a</font></td>
<td><font color=#F92663>42.91</font></td>
<td><font color=#F92663>43.48</font></td>
<td><font color=#F92663>0.572</font></td>
<td><font color=#F92663>101.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14b</font></td>
<td><font color=#6F9915>42.68</font></td>
<td><font color=#6F9915>42.11</font></td>
<td><font color=#6F9915>-0.566</font></td>
<td><font color=#6F9915>98.67%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>2.41</font></td>
<td><font color=#F92663>2.47</font></td>
<td><font color=#F92663>0.054</font></td>
<td><font color=#F92663>102.23%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>38.87</font></td>
<td><font color=#F92663>39.07</font></td>
<td><font color=#F92663>0.200</font></td>
<td><font color=#F92663>100.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>5.15</font></td>
<td><font color=#F92663>5.98</font></td>
<td><font color=#F92663>0.833</font></td>
<td><font color=#F92663>116.17%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>7.14</font></td>
<td><font color=#6F9915>6.12</font></td>
<td><font color=#6F9915>-1.021</font></td>
<td><font color=#6F9915>85.69%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>3.08</font></td>
<td><font color=#6F9915>2.02</font></td>
<td><font color=#6F9915>-1.060</font></td>
<td><font color=#6F9915>65.53%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>1.52</font></td>
<td><font color=#6F9915>1.39</font></td>
<td><font color=#6F9915>-0.129</font></td>
<td><font color=#6F9915>91.47%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>1.08</font></td>
<td><font color=#6F9915>1.00</font></td>
<td><font color=#6F9915>-0.072</font></td>
<td><font color=#6F9915>93.30%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>8.31</font></td>
<td><font color=#F92663>11.63</font></td>
<td><font color=#F92663>3.319</font></td>
<td><font color=#F92663>139.94%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q23a</font></td>
<td><font color=#6F9915>81.56</font></td>
<td><font color=#6F9915>79.90</font></td>
<td><font color=#6F9915>-1.661</font></td>
<td><font color=#6F9915>97.96%</font></td>
</tr>
<tr>
<td><font color=#F92663>q23b</font></td>
<td><font color=#F92663>101.64</font></td>
<td><font color=#F92663>105.25</font></td>
<td><font color=#F92663>3.607</font></td>
<td><font color=#F92663>103.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q24a</font></td>
<td><font color=#F92663>78.23</font></td>
<td><font color=#F92663>81.05</font></td>
<td><font color=#F92663>2.818</font></td>
<td><font color=#F92663>103.60%</font></td>
</tr>
<tr>
<td><font color=#F92663>q24b</font></td>
<td><font color=#F92663>72.61</font></td>
<td><font color=#F92663>76.38</font></td>
<td><font color=#F92663>3.764</font></td>
<td><font color=#F92663>105.18%</font></td>
</tr>
<tr>
<td><font color=#F92663>q25</font></td>
<td><font color=#F92663>5.88</font></td>
<td><font color=#F92663>5.97</font></td>
<td><font color=#F92663>0.093</font></td>
<td><font color=#F92663>101.58%</font></td>
</tr>
<tr>
<td><font color=#F92663>q26</font></td>
<td><font color=#F92663>2.55</font></td>
<td><font color=#F92663>4.38</font></td>
<td><font color=#F92663>1.833</font></td>
<td><font color=#F92663>171.90%</font></td>
</tr>
<tr>
<td><font color=#F92663>q27</font></td>
<td><font color=#F92663>2.96</font></td>
<td><font color=#F92663>3.02</font></td>
<td><font color=#F92663>0.057</font></td>
<td><font color=#F92663>101.93%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q28</font></td>
<td><font color=#6F9915>22.91</font></td>
<td><font color=#6F9915>22.59</font></td>
<td><font color=#6F9915>-0.320</font></td>
<td><font color=#6F9915>98.60%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q29</font></td>
<td><font color=#6F9915>8.19</font></td>
<td><font color=#6F9915>6.84</font></td>
<td><font color=#6F9915>-1.358</font></td>
<td><font color=#6F9915>83.42%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q30</font></td>
<td><font color=#6F9915>4.20</font></td>
<td><font color=#6F9915>4.07</font></td>
<td><font color=#6F9915>-0.131</font></td>
<td><font color=#6F9915>96.87%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q31</font></td>
<td><font color=#6F9915>7.38</font></td>
<td><font color=#6F9915>5.82</font></td>
<td><font color=#6F9915>-1.568</font></td>
<td><font color=#6F9915>78.76%</font></td>
</tr>
<tr>
<td><font color=#F92663>q32</font></td>
<td><font color=#F92663>0.96</font></td>
<td><font color=#F92663>1.07</font></td>
<td><font color=#F92663>0.109</font></td>
<td><font color=#F92663>111.35%</font></td>
</tr>
<tr>
<td><font color=#F92663>q33</font></td>
<td><font color=#F92663>5.93</font></td>
<td><font color=#F92663>7.28</font></td>
<td><font color=#F92663>1.353</font></td>
<td><font color=#F92663>122.81%</font></td>
</tr>
<tr>
<td><font color=#F92663>q34</font></td>
<td><font color=#F92663>4.97</font></td>
<td><font color=#F92663>5.28</font></td>
<td><font color=#F92663>0.310</font></td>
<td><font color=#F92663>106.23%</font></td>
</tr>
<tr>
<td><font color=#F92663>q35</font></td>
<td><font color=#F92663>6.58</font></td>
<td><font color=#F92663>9.42</font></td>
<td><font color=#F92663>2.842</font></td>
<td><font color=#F92663>143.23%</font></td>
</tr>
<tr>
<td><font color=#F92663>q36</font></td>
<td><font color=#F92663>2.97</font></td>
<td><font color=#F92663>3.01</font></td>
<td><font color=#F92663>0.042</font></td>
<td><font color=#F92663>101.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q37</font></td>
<td><font color=#F92663>3.79</font></td>
<td><font color=#F92663>3.93</font></td>
<td><font color=#F92663>0.139</font></td>
<td><font color=#F92663>103.66%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q38</font></td>
<td><font color=#6F9915>15.46</font></td>
<td><font color=#6F9915>12.10</font></td>
<td><font color=#6F9915>-3.353</font></td>
<td><font color=#6F9915>78.31%</font></td>
</tr>
<tr>
<td><font color=#F92663>q39a</font></td>
<td><font color=#F92663>3.16</font></td>
<td><font color=#F92663>3.35</font></td>
<td><font color=#F92663>0.193</font></td>
<td><font color=#F92663>106.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q39b</font></td>
<td><font color=#6F9915>2.72</font></td>
<td><font color=#6F9915>2.70</font></td>
<td><font color=#6F9915>-0.025</font></td>
<td><font color=#6F9915>99.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q40</font></td>
<td><font color=#F92663>3.96</font></td>
<td><font color=#F92663>4.06</font></td>
<td><font color=#F92663>0.109</font></td>
<td><font color=#F92663>102.74%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q41</font></td>
<td><font color=#6F9915>0.56</font></td>
<td><font color=#6F9915>0.54</font></td>
<td><font color=#6F9915>-0.022</font></td>
<td><font color=#6F9915>96.16%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q42</font></td>
<td><font color=#6F9915>0.79</font></td>
<td><font color=#6F9915>0.79</font></td>
<td><font color=#6F9915>-0.003</font></td>
<td><font color=#6F9915>99.61%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q43</font></td>
<td><font color=#6F9915>3.58</font></td>
<td><font color=#6F9915>3.50</font></td>
<td><font color=#6F9915>-0.083</font></td>
<td><font color=#6F9915>97.69%</font></td>
</tr>
<tr>
<td><font color=#F92663>q44</font></td>
<td><font color=#F92663>6.74</font></td>
<td><font color=#F92663>6.96</font></td>
<td><font color=#F92663>0.216</font></td>
<td><font color=#F92663>103.21%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q45</font></td>
<td><font color=#6F9915>3.40</font></td>
<td><font color=#6F9915>3.28</font></td>
<td><font color=#6F9915>-0.115</font></td>
<td><font color=#6F9915>96.61%</font></td>
</tr>
<tr>
<td><font color=#F92663>q46</font></td>
<td><font color=#F92663>2.93</font></td>
<td><font color=#F92663>4.17</font></td>
<td><font color=#F92663>1.247</font></td>
<td><font color=#F92663>142.61%</font></td>
</tr>
<tr>
<td><font color=#F92663>q47</font></td>
<td><font color=#F92663>13.95</font></td>
<td><font color=#F92663>14.50</font></td>
<td><font color=#F92663>0.552</font></td>
<td><font color=#F92663>103.95%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q48</font></td>
<td><font color=#6F9915>4.21</font></td>
<td><font color=#6F9915>4.09</font></td>
<td><font color=#6F9915>-0.120</font></td>
<td><font color=#6F9915>97.15%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q49</font></td>
<td><font color=#6F9915>11.08</font></td>
<td><font color=#6F9915>7.28</font></td>
<td><font color=#6F9915>-3.801</font></td>
<td><font color=#6F9915>65.69%</font></td>
</tr>
<tr>
<td><font color=#F92663>q50</font></td>
<td><font color=#F92663>21.52</font></td>
<td><font color=#F92663>23.39</font></td>
<td><font color=#F92663>1.866</font></td>
<td><font color=#F92663>108.67%</font></td>
</tr>
<tr>
<td><font color=#F92663>q51</font></td>
<td><font color=#F92663>8.29</font></td>
<td><font color=#F92663>8.38</font></td>
<td><font color=#F92663>0.097</font></td>
<td><font color=#F92663>101.17%</font></td>
</tr>
<tr>
<td><font color=#F92663>q52</font></td>
<td><font color=#F92663>0.91</font></td>
<td><font color=#F92663>0.96</font></td>
<td><font color=#F92663>0.052</font></td>
<td><font color=#F92663>105.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q53</font></td>
<td><font color=#F92663>1.63</font></td>
<td><font color=#F92663>1.66</font></td>
<td><font color=#F92663>0.027</font></td>
<td><font color=#F92663>101.66%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q54</font></td>
<td><font color=#6F9915>3.03</font></td>
<td><font color=#6F9915>2.97</font></td>
<td><font color=#6F9915>-0.065</font></td>
<td><font color=#6F9915>97.86%</font></td>
</tr>
<tr>
<td><font color=#F92663>q55</font></td>
<td><font color=#F92663>0.89</font></td>
<td><font color=#F92663>0.91</font></td>
<td><font color=#F92663>0.018</font></td>
<td><font color=#F92663>102.02%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q56</font></td>
<td><font color=#6F9915>5.49</font></td>
<td><font color=#6F9915>5.34</font></td>
<td><font color=#6F9915>-0.153</font></td>
<td><font color=#6F9915>97.22%</font></td>
</tr>
<tr>
<td><font color=#F92663>q57</font></td>
<td><font color=#F92663>8.17</font></td>
<td><font color=#F92663>8.27</font></td>
<td><font color=#F92663>0.103</font></td>
<td><font color=#F92663>101.26%</font></td>
</tr>
<tr>
<td><font color=#F92663>q58</font></td>
<td><font color=#F92663>2.34</font></td>
<td><font color=#F92663>2.39</font></td>
<td><font color=#F92663>0.056</font></td>
<td><font color=#F92663>102.39%</font></td>
</tr>
<tr>
<td><font color=#F92663>q59</font></td>
<td><font color=#F92663>15.67</font></td>
<td><font color=#F92663>17.40</font></td>
<td><font color=#F92663>1.727</font></td>
<td><font color=#F92663>111.02%</font></td>
</tr>
<tr>
<td><font color=#F92663>q60</font></td>
<td><font color=#F92663>5.66</font></td>
<td><font color=#F92663>5.81</font></td>
<td><font color=#F92663>0.153</font></td>
<td><font color=#F92663>102.70%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q61</font></td>
<td><font color=#6F9915>6.28</font></td>
<td><font color=#6F9915>6.17</font></td>
<td><font color=#6F9915>-0.109</font></td>
<td><font color=#6F9915>98.27%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q62</font></td>
<td><font color=#6F9915>4.53</font></td>
<td><font color=#6F9915>3.91</font></td>
<td><font color=#6F9915>-0.614</font></td>
<td><font color=#6F9915>86.43%</font></td>
</tr>
<tr>
<td><font color=#F92663>q63</font></td>
<td><font color=#F92663>1.82</font></td>
<td><font color=#F92663>1.85</font></td>
<td><font color=#F92663>0.029</font></td>
<td><font color=#F92663>101.56%</font></td>
</tr>
<tr>
<td><font color=#F92663>q64</font></td>
<td><font color=#F92663>48.88</font></td>
<td><font color=#F92663>49.77</font></td>
<td><font color=#F92663>0.893</font></td>
<td><font color=#F92663>101.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q65</font></td>
<td><font color=#6F9915>14.68</font></td>
<td><font color=#6F9915>13.73</font></td>
<td><font color=#6F9915>-0.947</font></td>
<td><font color=#6F9915>93.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q66</font></td>
<td><font color=#F92663>2.82</font></td>
<td><font color=#F92663>2.86</font></td>
<td><font color=#F92663>0.033</font></td>
<td><font color=#F92663>101.16%</font></td>
</tr>
<tr>
<td><font color=#F92663>q67</font></td>
<td><font color=#F92663>349.14</font></td>
<td><font color=#F92663>351.37</font></td>
<td><font color=#F92663>2.236</font></td>
<td><font color=#F92663>100.64%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q68</font></td>
<td><font color=#6F9915>3.65</font></td>
<td><font color=#6F9915>3.59</font></td>
<td><font color=#6F9915>-0.063</font></td>
<td><font color=#6F9915>98.29%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q69</font></td>
<td><font color=#6F9915>9.48</font></td>
<td><font color=#6F9915>6.37</font></td>
<td><font color=#6F9915>-3.110</font></td>
<td><font color=#6F9915>67.19%</font></td>
</tr>
<tr>
<td><font color=#F92663>q70</font></td>
<td><font color=#F92663>8.49</font></td>
<td><font color=#F92663>9.30</font></td>
<td><font color=#F92663>0.810</font></td>
<td><font color=#F92663>109.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q71</font></td>
<td><font color=#F92663>2.03</font></td>
<td><font color=#F92663>3.06</font></td>
<td><font color=#F92663>1.027</font></td>
<td><font color=#F92663>150.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q72</font></td>
<td><font color=#6F9915>189.72</font></td>
<td><font color=#6F9915>186.98</font></td>
<td><font color=#6F9915>-2.733</font></td>
<td><font color=#6F9915>98.56%</font></td>
</tr>
<tr>
<td><font color=#F92663>q73</font></td>
<td><font color=#F92663>2.06</font></td>
<td><font color=#F92663>2.17</font></td>
<td><font color=#F92663>0.109</font></td>
<td><font color=#F92663>105.26%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q74</font></td>
<td><font color=#6F9915>21.11</font></td>
<td><font color=#6F9915>21.07</font></td>
<td><font color=#6F9915>-0.035</font></td>
<td><font color=#6F9915>99.83%</font></td>
</tr>
<tr>
<td><font color=#F92663>q75</font></td>
<td><font color=#F92663>24.75</font></td>
<td><font color=#F92663>25.14</font></td>
<td><font color=#F92663>0.390</font></td>
<td><font color=#F92663>101.58%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q76</font></td>
<td><font color=#6F9915>10.26</font></td>
<td><font color=#6F9915>7.57</font></td>
<td><font color=#6F9915>-2.688</font></td>
<td><font color=#6F9915>73.80%</font></td>
</tr>
<tr>
<td><font color=#F92663>q77</font></td>
<td><font color=#F92663>1.60</font></td>
<td><font color=#F92663>1.78</font></td>
<td><font color=#F92663>0.174</font></td>
<td><font color=#F92663>110.84%</font></td>
</tr>
<tr>
<td><font color=#F92663>q78</font></td>
<td><font color=#F92663>38.47</font></td>
<td><font color=#F92663>39.89</font></td>
<td><font color=#F92663>1.417</font></td>
<td><font color=#F92663>103.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q79</font></td>
<td><font color=#F92663>3.36</font></td>
<td><font color=#F92663>3.40</font></td>
<td><font color=#F92663>0.038</font></td>
<td><font color=#F92663>101.14%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q80</font></td>
<td><font color=#6F9915>11.26</font></td>
<td><font color=#6F9915>11.10</font></td>
<td><font color=#6F9915>-0.163</font></td>
<td><font color=#6F9915>98.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q81</font></td>
<td><font color=#6F9915>5.82</font></td>
<td><font color=#6F9915>4.27</font></td>
<td><font color=#6F9915>-1.548</font></td>
<td><font color=#6F9915>73.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q82</font></td>
<td><font color=#F92663>6.69</font></td>
<td><font color=#F92663>8.91</font></td>
<td><font color=#F92663>2.220</font></td>
<td><font color=#F92663>133.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q83</font></td>
<td><font color=#6F9915>1.40</font></td>
<td><font color=#6F9915>1.32</font></td>
<td><font color=#6F9915>-0.073</font></td>
<td><font color=#6F9915>94.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q84</font></td>
<td><font color=#F92663>2.88</font></td>
<td><font color=#F92663>3.06</font></td>
<td><font color=#F92663>0.185</font></td>
<td><font color=#F92663>106.42%</font></td>
</tr>
<tr>
<td><font color=#F92663>q85</font></td>
<td><font color=#F92663>6.77</font></td>
<td><font color=#F92663>7.26</font></td>
<td><font color=#F92663>0.487</font></td>
<td><font color=#F92663>107.19%</font></td>
</tr>
<tr>
<td><font color=#F92663>q86</font></td>
<td><font color=#F92663>3.24</font></td>
<td><font color=#F92663>3.24</font></td>
<td><font color=#F92663>0.003</font></td>
<td><font color=#F92663>100.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q87</font></td>
<td><font color=#F92663>12.10</font></td>
<td><font color=#F92663>12.13</font></td>
<td><font color=#F92663>0.031</font></td>
<td><font color=#F92663>100.26%</font></td>
</tr>
<tr>
<td><font color=#F92663>q88</font></td>
<td><font color=#F92663>16.59</font></td>
<td><font color=#F92663>17.29</font></td>
<td><font color=#F92663>0.705</font></td>
<td><font color=#F92663>104.25%</font></td>
</tr>
<tr>
<td><font color=#F92663>q89</font></td>
<td><font color=#F92663>2.58</font></td>
<td><font color=#F92663>4.61</font></td>
<td><font color=#F92663>2.034</font></td>
<td><font color=#F92663>179.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q90</font></td>
<td><font color=#F92663>3.06</font></td>
<td><font color=#F92663>3.10</font></td>
<td><font color=#F92663>0.039</font></td>
<td><font color=#F92663>101.27%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q91</font></td>
<td><font color=#6F9915>5.66</font></td>
<td><font color=#6F9915>2.85</font></td>
<td><font color=#6F9915>-2.814</font></td>
<td><font color=#6F9915>50.32%</font></td>
</tr>
<tr>
<td><font color=#F92663>q92</font></td>
<td><font color=#F92663>1.23</font></td>
<td><font color=#F92663>1.23</font></td>
<td><font color=#F92663>0.006</font></td>
<td><font color=#F92663>100.53%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q93</font></td>
<td><font color=#6F9915>30.20</font></td>
<td><font color=#6F9915>29.83</font></td>
<td><font color=#6F9915>-0.371</font></td>
<td><font color=#6F9915>98.77%</font></td>
</tr>
<tr>
<td><font color=#F92663>q94</font></td>
<td><font color=#F92663>21.20</font></td>
<td><font color=#F92663>21.35</font></td>
<td><font color=#F92663>0.147</font></td>
<td><font color=#F92663>100.69%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>87.60</font></td>
<td><font color=#6F9915>84.69</font></td>
<td><font color=#6F9915>-2.912</font></td>
<td><font color=#6F9915>96.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>2.23</font></td>
<td><font color=#F92663>2.55</font></td>
<td><font color=#F92663>0.318</font></td>
<td><font color=#F92663>114.24%</font></td>
</tr>
<tr>
<td><font color=#F92663>q96</font></td>
<td><font color=#F92663>12.16</font></td>
<td><font color=#F92663>12.41</font></td>
<td><font color=#F92663>0.251</font></td>
<td><font color=#F92663>102.07%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q97</font></td>
<td><font color=#6F9915>1.92</font></td>
<td><font color=#6F9915>1.87</font></td>
<td><font color=#6F9915>-0.051</font></td>
<td><font color=#6F9915>97.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q98</font></td>
<td><font color=#6F9915>9.47</font></td>
<td><font color=#6F9915>8.29</font></td>
<td><font color=#6F9915>-1.181</font></td>
<td><font color=#6F9915>87.53%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q99</font></td>
<td><font color=#6F9915>9.47</font></td>
<td><font color=#6F9915>8.29</font></td>
<td><font color=#6F9915>-1.181</font></td>
<td><font color=#6F9915>87.53%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1890.24</font></td>
<td><font color=#F92663>1902.59</font></td>
<td><font color=#F92663>12.348</font></td>
<td><font color=#F92663>100.65%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "yma11 (via GitHub)" <gi...@apache.org>.
yma11 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106682216
> @yma11 Did you reproduced the problem I mentioned above based on the master gluten branch? That is what I'm trying to fix.
I mean which part of your code changes in this PR is the fix? Seems only some code refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch when RDD partition num > 1 [incubator-gluten]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5711:
URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106806866
> > @yma11 Did you reproduced the problem I mentioned above based on the master gluten branch? That is what I'm trying to fix.
>
> I mean which part of your code changes in this PR is the fix? Seems only some code refactor?
Before this PR, `RowConstructorWithAllNullCallToSpecialForm.constructSpecialForm` was not called when function name was `row_constructor_with_all_null`.
I think it was related to C++ overload/override mechanism.
In this PR, I take function name as a member of `RowConstructorWithNullCallToSpecialForm` to avoid the overload/override issues and fix the result mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org