You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:58:51 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #11542: Rename (confusing) dag.sub_dag method to dag.partial_subset

kaxil commented on a change in pull request #11542:
URL: https://github.com/apache/airflow/pull/11542#discussion_r505451207



##########
File path: airflow/models/dag.py
##########
@@ -1347,8 +1347,18 @@ def __deepcopy__(self, memo):
             result._log = self._log
         return result
 
-    def sub_dag(self, task_regex, include_downstream=False,
-                include_upstream=True):
+    def sub_dag(self, *args, **kwargs):
+        """This method is deprecated in favor of partial_subset"""
+        warnings.warn(
+            "This method is deprecated and will be removed in a future version. Please use partial_subset",
+            DeprecationWarning,
+            stacklevel=2,

Review comment:
       Can we add this in Updating.md too, please ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org