You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:46:23 UTC

[GitHub] [camel] yasserzamani commented on a diff in pull request #8944: [CAMEL-15111] Fixes bug in camel-as2 via not forcing ascii charset when not specified

yasserzamani commented on code in PR #8944:
URL: https://github.com/apache/camel/pull/8944#discussion_r1056189327


##########
components/camel-as2/camel-as2-api/pom.xml:
##########
@@ -96,6 +96,13 @@
             <artifactId>camel-test-junit5</artifactId>
             <scope>test</scope>
         </dependency>
+        <!-- added for binary content transfer encoding test because Camel AS2 client doesn't support binary currently -->
+        <dependency>
+            <groupId>com.helger.as2</groupId>
+            <artifactId>as2-lib</artifactId>
+            <version>4.11.0</version>
+            <scope>test</scope>

Review Comment:
   Thanks! There were a lot to do and I forgot to do so while I was going to. Nice catch :+1: fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org