[jira] [Commented] (DRILL-7351) WebUI is Vulnerable to CSRF

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941832#comment-16941832 ] 

ASF GitHub Bot commented on DRILL-7351:
---------------------------------------

arina-ielchiieva commented on pull request #1864: DRILL-7351: Added tokens to Web forms to prevent CSRF attacks
URL: https://github.com/apache/drill/pull/1864#discussion_r329995840
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/CsrfTokenValidateFilter.java
 ##########
 @@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.server.rest;
+
+import org.apache.drill.exec.util.Utilities;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.FilterConfig;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.ws.rs.HttpMethod;
+import java.io.IOException;
+
+/**
+ * All forms on site have a field with a CSRF token injected by server.
+ * This filter compares the token with one stored in the session to ensure that the POST request is not a CSRF attack.
+ */
+public class CsrfTokenValidateFilter implements Filter {
+  @Override
+  public void init(FilterConfig filterConfig) throws ServletException {
+
+  }
+
+  @Override
+  public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
+    HttpServletRequest httpRequest = (HttpServletRequest) request;
+    HttpServletResponse httpResponse = (HttpServletResponse) response;
+    if (HttpMethod.POST.equalsIgnoreCase(httpRequest.getMethod())) {
+      String csrfTokenSession = Utilities.getCsrfTokenFromHttpRequest(httpRequest);
+      String csrfTokenRequest = httpRequest.getParameter(WebServerConstants.CSRF_TOKEN);
+      if (!csrfTokenSession.equals(csrfTokenRequest)) {
+        httpResponse.reset();
+        httpResponse.sendError(HttpServletResponse.SC_FORBIDDEN, "Potential CSRF detected");
+        return;
+      }
+    }
+    chain.doFilter(request, response);
+  }
+
+  @Override
+  public void destroy() {
+
 
 Review comment:
   Remove new line.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> WebUI is Vulnerable to CSRF
> ---------------------------
>
>                 Key: DRILL-7351
>                 URL: https://issues.apache.org/jira/browse/DRILL-7351
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.16.0
>            Reporter: Don Perial
>            Assignee: Anton Gozhiy
>            Priority: Major
>             Fix For: 1.17.0
>
>         Attachments: Screen Shot 2019-08-19 at 10.11.50 AM.png, drill-csrf.html
>
>
> There is no way to protect the WebUI from CSRF and the fact that the value for the access-control-allow-origin header is '*' appears to confound this issue as well.
> The attached file demonstrates the vulnerability.
> Steps to replicate:
>  # Login to an instance of the Drill WebUI.
>  # Edit the attached [^drill-csrf.html]. Replace DRILL_HOST with the hostname of the Drill WebUI from step #1.
>  # Load the file from #2 in the same browser as #1 either new tab or same window will do.
>  # Return to the Drill WebUI and click on 'Profiles'.
> Observed results:
> The query 'SELECT 100' appears in the list of executed queries (see:  [^Screen Shot 2019-08-19 at 10.11.50 AM.png] ).
> Expected results:
> It should be possible to whitelist or completely restrict code from other domain names to submit queries to the WebUI.
> Risks:
> Potential for code execution by unauthorized parties.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)