[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #775: Enable modlib_findsection

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #775: Enable modlib_findsection
URL: https://github.com/apache/incubator-nuttx/pull/775#discussion_r407508184
 
 

 ##########
 File path: libs/libc/modlib/modlib_sections.c
 ##########
 @@ -66,6 +66,7 @@
  *
  ****************************************************************************/
 
+#if 0 /* Not used */
 
 Review comment:
   > i think you added #if 0 on modlib_findsection. do you have any opinion?
   
   If it isn't used, why waste memory.
   
   It seems to me that there are two global functions in that file that are not closely related.  I think they should pull out into separate files.  I would do this:
   
   1) Move modlib_loadshdrs() into a new file.  I don't understand why it is in that file, and
   2) Remove the #if 0
   
   Then modlib_findsection() will be brought into build only if it is used with no dependency to lto.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services