[GitHub] metron pull request #1168: METRON-1739: UDP packets are not handled

[merrimanr <gi...@git.apache.org>]

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/1168

    METRON-1739: UDP packets are not handled

    ## Contributor Comments
    Currently only TCP packets are included in query results when fixed field filters are applied.  In the case where no filters are applied, UDP packet fields are not displayed in the UI.  This PR fixes both issues.
    
    ### Changes Included
    - updated the PcapHelper class to properly detect and parse UDP packets
    - moved the protocol parsing logic out of the tcp if block
    - the UI now populates UDP src and dst ports
    - added unit tests to cover each case
    - added mock UDP data to the UI unit tests
    
    ### Testing
    This has been tested in full dev:
    
    1. Generate data using pycapa and the Pcap topology (should include UDP packets)
    2. Navigate to the Pcap UI and run a query with the `Protocol` filter set to `17`
    3. Results should be returned and the all fields including src and dst port should be populated
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1739

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1168
    
----
commit 2cd6c28199601c1dfea33a3799dd506df8961241
Author: merrimanr <me...@...>
Date:   2018-08-16T21:25:25Z

    initial commit

----


---

[GitHub] metron issue #1168: METRON-1739: UDP packets are not handled

[james-sirota <gi...@git.apache.org>]

Github user james-sirota commented on the issue:

    https://github.com/apache/metron/pull/1168
  
    +1 I was able to get a demo of the fix from Ryan.  I can attest that it works 


---

[GitHub] metron pull request #1168: METRON-1739: UDP packets are not handled

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1168


---