[GitHub] brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js

[GitBox <gi...@apache.org>]

brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js
URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438845851
 
 
   > Why is a PR with failing tests being merged?
   
   It is a build error, no actually failing tests.
   
   I deleted my branch right after merge, that is what caused the failure. I didn't see the failure.
   
   I tried restoring my branch and restarting the build a couple times. Unfortunately it didn't seem to work. It should go green in the next merge.
   
   > Why does this PR contain a lot more than it says in the PR title?
   
   I just updated the title.
   
   Purpose was only to mark 8.0.0-dev. But the procedure involves regenerating cordova.js, and I wanted to do that in a couple smaller steps, to avoid excessive changes combined in a single commit.
   
   > Why does this PR refer to a WIP and unmerged coho PR?
   
   I have some enhancements that help me update cordova.js from a specific cordova-js version. There is quite a bit of review feedback on the PR and I did not a chance to process it. I just updated the description with some more info.
   
   Alternative would be to close the WIP PR on cordova-coho and use my own fork, without giving record of what commands I used to do the update.
   
   I will admit that this update did not go quite right, not much we can do now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org