You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2015/02/05 16:00:07 UTC
[1/2] trafficserver git commit: TS-3287: Close socket to prevent
resource leak
Repository: trafficserver
Updated Branches:
refs/heads/master 20b25d62e -> d19a88b0d
TS-3287: Close socket to prevent resource leak
Coverity CID #1022130
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d19a88b0
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d19a88b0
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d19a88b0
Branch: refs/heads/master
Commit: d19a88b0df8baeb01e9215b73c658c20fdd72f2e
Parents: 7ac50d8
Author: Phil Sorber <so...@apache.org>
Authored: Thu Feb 5 07:55:12 2015 -0700
Committer: Phil Sorber <so...@apache.org>
Committed: Thu Feb 5 07:59:44 2015 -0700
----------------------------------------------------------------------
tools/jtest/jtest.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d19a88b0/tools/jtest/jtest.cc
----------------------------------------------------------------------
diff --git a/tools/jtest/jtest.cc b/tools/jtest/jtest.cc
index 7f03971..187994e 100644
--- a/tools/jtest/jtest.cc
+++ b/tools/jtest/jtest.cc
@@ -2326,6 +2326,7 @@ static int make_client (unsigned int addr, int port) {
break;
if (verbose_errors) fprintf(stderr, "connect failed errno = %d\n", errno);
errors++;
+ close(sock);
return -1;
}
[2/2] trafficserver git commit: TS-3287: Close socket to prevent
resource leak
Posted by so...@apache.org.
TS-3287: Close socket to prevent resource leak
Coverity CID #1022129
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/7ac50d86
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/7ac50d86
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/7ac50d86
Branch: refs/heads/master
Commit: 7ac50d860015e1cce1e7b3d19d4eb07d42a583d8
Parents: 20b25d6
Author: Phil Sorber <so...@apache.org>
Authored: Thu Feb 5 07:58:37 2015 -0700
Committer: Phil Sorber <so...@apache.org>
Committed: Thu Feb 5 07:59:44 2015 -0700
----------------------------------------------------------------------
tools/jtest/jtest.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/7ac50d86/tools/jtest/jtest.cc
----------------------------------------------------------------------
diff --git a/tools/jtest/jtest.cc b/tools/jtest/jtest.cc
index 046c26f..7f03971 100644
--- a/tools/jtest/jtest.cc
+++ b/tools/jtest/jtest.cc
@@ -1401,8 +1401,10 @@ static int open_server(unsigned short int port, accept_fn_t accept_fn) {
exit( EXIT_FAILURE);
}
if ((err=bind (sock, (struct sockaddr *) &name, sizeof (name))) < 0) {
- if (errno == EADDRINUSE)
+ if (errno == EADDRINUSE) {
+ close(sock);
return -EADDRINUSE;
+ }
perror("bind");
exit( EXIT_FAILURE);
}