You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2024/11/07 12:18:07 UTC

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22039


Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for
IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
9 files changed, 228 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17703/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 08:44:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17916/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2025 10:44:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11313/


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 01:23:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11316/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 10
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 08:51:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

LGTM!

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test:

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test@304
PS6, Line 304: a
nit: no need for 'a'


http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test:

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test@715
PS6, Line 715: source.id
small suggestion: it would be easier to understand the RESULTS section if it was 'source.id + 100'



-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 14:17:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17917/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2025 10:56:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17974/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 9
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 08:50:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 1:

(2 comments)

Thanks for working on this!

http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@8
PS1, Line 8: IcebergMergeImpl
nit: there shouldn't be a line break


http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@15
PS1, Line 15: Tests
Could you please add simple e2e tests as well where we could check the results?

Could you please also add tests for the case when the source table is masked/filtered, e.g. like in https://gerrit.cloudera.org/#/c/20127/3/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test



-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 17:29:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 328 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17705/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 13:36:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22039

to look at the new patch set (#5).

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 331 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11313/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:53:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 10
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 08:51:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 7: Code-Review+2

(2 comments)

Carrying Zoltan's +2

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test:

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test@304
PS6, Line 304: g
> nit: no need for 'a'
Done


http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test:

http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test@715
PS6, Line 715: cast(sour
> small suggestion: it would be easier to understand the RESULTS section if i
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:23:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22039

to look at the new patch set (#4).

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 333 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17902/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jan 2025 13:09:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 10
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 14:23:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 331 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/7
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@8
PS1, Line 8: 
> nit: there shouldn't be a line break
Done


http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@15
PS1, Line 15:  - Pl
> Could you please add simple e2e tests as well where we could check the resu
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 08:20:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
11 files changed, 290 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 331 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/9
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 9
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17965/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:50:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 331 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/22039/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 9: Code-Review+2

Updated planner test string mismatch
Carrying Zoltan's +2


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 9
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 08:25:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:53:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................

IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

This change enables MERGE statements with source expressions containing
subqueries that require rewrite. The change adds implementation for
reset methods for each merge case, and properly handles resets for
MergeStmt and IcebergMergeImpl.

Tests:
 - Planner test added with a merge query that requires a rewrite
 - Analyzer test modified

Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Reviewed-on: http://gerrit.cloudera.org:8080/22039
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeCase.java
M fe/src/main/java/org/apache/impala/analysis/MergeImpl.java
M fe/src/main/java/org/apache/impala/analysis/MergeInsert.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeUpdate.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
12 files changed, 331 insertions(+), 36 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 11
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )

Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17405/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2024 12:43:45 +0000
Gerrit-HasComments: No