You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/13 09:23:46 UTC

[GitHub] [skywalking-cli] fgksgf commented on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities

fgksgf commented on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743978242


   > I think this PR missed one important step, verification. The test passed doesn't only mean `runnable` w/o exception, also should check the expected data.
   
   Yes, as the [issue](https://github.com/apache/skywalking/issues/5985) inferred, this is just a simple test. I think the verification would be part of the next generation E2E test framework. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org