You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Dan Diephouse (JIRA)" <be...@incubator.apache.org> on 2004/11/11 16:40:23 UTC

[jira] Created: (BEEHIVE-84) Generate error if @ControlImplementation is missing

Generate error if @ControlImplementation is missing
---------------------------------------------------

         Key: BEEHIVE-84
         URL: http://nagoya.apache.org/jira/browse/BEEHIVE-84
     Project: Beehive
        Type: Improvement
  Components: Controls  
    Reporter: Dan Diephouse


It would be nice if when you forgot to put a @ControlImplementation annotation on your implementation class, Beehive generated some sort of error. Currently when you try to use the control it will just give a class not found exception for the ControlImplInitializer class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-84) Generate error if @ControlImplementation is missing

Posted by "Jeremiah Johnson (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-84?page=all ]
     
Jeremiah Johnson closed BEEHIVE-84:
-----------------------------------

    Assign To: Jeremiah Johnson

Verified in dist build from SVN 169852.

Verified with external bindings and worked as expected: the file reference in the controlbindings.properties file didn't have ControlImplementation and correct error resulted.  Verified with implicit binding (Impl appended to Control interface name) and worked as expected.  Finally, tested using defaultBinding set on the ControlInterface and worked as expected.

Error message:
org.apache.beehive.controls.api.ControlException: @org.apache.beehive.controls.api.bean.ControlImplementation annotation is missing from control implementation class: web.OracleSaleDao

Of course, the last part of the error message changed to web.SaleDaoImpl and web.DerbySaleDao as expected.

> Generate error if @ControlImplementation is missing
> ---------------------------------------------------
>
>          Key: BEEHIVE-84
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-84
>      Project: Beehive
>         Type: Improvement
>   Components: Controls
>     Reporter: Dan Diephouse
>     Assignee: Jeremiah Johnson
>      Fix For: V1Beta

>
> It would be nice if when you forgot to put a @ControlImplementation annotation on your implementation class, Beehive generated some sort of error. Currently when you try to use the control it will just give a class not found exception for the ControlImplInitializer class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-84) Generate error if @ControlImplementation is missing

Posted by "Kyle Marvin (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-84?page=history ]

Kyle Marvin reassigned BEEHIVE-84:
----------------------------------

    Assign To: Kyle Marvin

> Generate error if @ControlImplementation is missing
> ---------------------------------------------------
>
>          Key: BEEHIVE-84
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-84
>      Project: Beehive
>         Type: Improvement
>   Components: Controls
>     Reporter: Dan Diephouse
>     Assignee: Kyle Marvin

>
> It would be nice if when you forgot to put a @ControlImplementation annotation on your implementation class, Beehive generated some sort of error. Currently when you try to use the control it will just give a class not found exception for the ControlImplInitializer class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-84) Generate error if @ControlImplementation is missing

Posted by "Kyle Marvin (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-84?page=history ]
     
Kyle Marvin resolved BEEHIVE-84:
--------------------------------

      Assign To:     (was: Kyle Marvin)
     Resolution: Fixed
    Fix Version: V1Beta

Added a construction-time check to ensure that any bound implementation class has the @ControlImplementation annotation.  It would be great to have this be a compile-time error, but its possible that for many simple controls this might be the only annotation present, so there is no way for an annotation processor to detect it.  At least this way, the error/fix is much more obvious.

Checked in as svn revision 155338.

> Generate error if @ControlImplementation is missing
> ---------------------------------------------------
>
>          Key: BEEHIVE-84
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-84
>      Project: Beehive
>         Type: Improvement
>   Components: Controls
>     Reporter: Dan Diephouse
>      Fix For: V1Beta

>
> It would be nice if when you forgot to put a @ControlImplementation annotation on your implementation class, Beehive generated some sort of error. Currently when you try to use the control it will just give a class not found exception for the ControlImplInitializer class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira