[GitHub] [hbase] virajjasani commented on a change in pull request #2904: HBASE-25528: Dedicated merge dispatch thread pool on master

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2904:
URL: https://github.com/apache/hbase/pull/2904#discussion_r564526039



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -208,14 +208,21 @@ public void setMasterServices(final MasterServices masterServices) {
       ctx.getTableRegions().size());
 
     final List<NormalizationPlan> plans = new ArrayList<>();
+    int splitPlansCount = 0;
     if (proceedWithSplitPlanning) {
-      plans.addAll(computeSplitNormalizationPlans(ctx));
+      List<NormalizationPlan> splitPlans = computeSplitNormalizationPlans(ctx);
+      splitPlansCount = splitPlans.size();
+      plans.addAll(splitPlans);
     }
+    int mergePlansCount = 0;
     if (proceedWithMergePlanning) {
-      plans.addAll(computeMergeNormalizationPlans(ctx));
+      List<NormalizationPlan> mergePlans = computeMergeNormalizationPlans(ctx);
+      mergePlansCount = mergePlans.size();
+      plans.addAll(mergePlans);
     }
 
-    LOG.debug("Computed {} normalization plans for table {}", plans.size(), table);
+    LOG.debug("Computed {} normalization plans for table {}. Split plans: {}, merge plans: {}",
+        plans.size(), table, splitPlansCount, mergePlansCount);

Review comment:
       Nice log. One small nit: `Computed total {} normalization plans....`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org