You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 10:37:32 UTC
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1515: test: front-end e2e test for rawDataEditor
guoqqqi opened a new pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
resolve #1506
___
### Please add the corresponding test cases if necessary.
Added tests for Route, Service, Upstream, Consumer for rawDataEditor
___
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1515: test: front-end e2e test for rawDataEditor
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515#discussion_r582736034
##########
File path: web/cypress/integration/route/create-edit-delete-route.spec.js
##########
@@ -85,6 +85,21 @@ context('Create and Delete Route', () => {
cy.url().should('contains', 'routes/list');
});
+ it('should view the route', function () {
+ cy.visit('/');
+ cy.contains('Route').click();
+
+ cy.get(this.domSelector.nameSelector).type(name);
+ cy.contains('Search').click();
+ cy.contains(name).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
ditto
##########
File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js
##########
@@ -56,6 +56,21 @@ context('Create and Delete Consumer', () => {
cy.get(this.domSelector.notification).should('contain', this.data.createConsumerSuccess);
});
+ it('should view the consumer', function () {
+ cy.visit('/');
+ cy.contains('Consumer').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.consumerName);
+ cy.contains('Search').click();
+ cy.contains(this.data.consumerName).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
```suggestion
cy.get(this.domSelector.xxx).should('be.visible');
```
##########
File path: web/cypress/integration/route/create-edit-delete-route.spec.js
##########
@@ -103,6 +118,15 @@ context('Create and Delete Route', () => {
cy.contains('Goto List').click();
cy.url().should('contains', 'routes/list');
cy.contains(newName).siblings().should('contain', this.data.description2);
+
+ // test view
+ cy.contains(newName).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
ditto
##########
File path: web/cypress/integration/service/create-edit-delete-service.spec.js
##########
@@ -40,6 +40,21 @@ context('create and delete service ', () => {
cy.get(this.domSelector.notification).should('contain', this.data.createServiceSuccess);
});
+ it('should view the service', function () {
+ cy.visit('/');
+ cy.contains('Service').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.serviceName);
+ cy.contains('Search').click();
+ cy.contains(this.data.serviceName).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
ditto
##########
File path: web/cypress/integration/service/create-edit-delete-service.spec.js
##########
@@ -59,10 +74,20 @@ context('create and delete service ', () => {
cy.contains('Next').click();
cy.contains('Submit').click();
cy.get(this.domSelector.notification).should('contain', this.data.editServiceSuccess);
+
+ // test view
+ cy.contains(this.data.serviceName2).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
ditto
##########
File path: web/cypress/integration/service/create-edit-delete-service.spec.js
##########
@@ -59,10 +74,20 @@ context('create and delete service ', () => {
cy.contains('Next').click();
cy.contains('Submit').click();
cy.get(this.domSelector.notification).should('contain', this.data.editServiceSuccess);
+
+ // test view
+ cy.contains(this.data.serviceName2).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
+
+ cy.get('.CodeMirror-scroll').within(() => {
Review comment:
```suggestion
cy.get(this.domSelector.xxx).within(() => {
```
##########
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##########
@@ -41,6 +41,22 @@ context('Create and Delete Upstream', () => {
cy.url().should('contains', 'upstream/list');
});
+ it('should view the (roundrobin) upstream', function () {
+ cy.visit('/');
+ cy.contains('Upstream').click();
+
+ cy.get(this.domSelector.nameSelector).type(this.data.upstreamName);
+ cy.contains('Search').click();
+ cy.contains(this.data.upstreamName).siblings().contains('View').click();
+ cy.get('.ant-drawer-content').should('be.visible');
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1515: test: front-end e2e test for rawDataEditor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515#issuecomment-785846719
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=h1) Report
> Merging [#1515](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=desc) (8f9589b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25c5b09ecf73112cde6e944c7721dce56247b94c?el=desc) (25c5b09) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 68.92% 68.59% -0.33%
==========================================
Files 48 48
Lines 3047 3047
==========================================
- Hits 2100 2090 -10
- Misses 707 717 +10
Partials 240 240
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-5.46%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.40% <0.00%> (-4.09%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=footer). Last update [25c5b09...8f9589b](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1515: test: front-end e2e test for rawDataEditor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515#issuecomment-785846719
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=h1) Report
> Merging [#1515](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=desc) (8f9589b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25c5b09ecf73112cde6e944c7721dce56247b94c?el=desc) (25c5b09) will **decrease** coverage by `17.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1515 +/- ##
===========================================
- Coverage 68.92% 51.69% -17.23%
===========================================
Files 48 39 -9
Lines 3047 2600 -447
===========================================
- Hits 2100 1344 -756
- Misses 707 1082 +375
+ Partials 240 174 -66
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=footer). Last update [25c5b09...8f9589b](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1515: test: front-end e2e test for rawDataEditor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515#issuecomment-785846719
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=h1) Report
> Merging [#1515](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=desc) (8f9589b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25c5b09ecf73112cde6e944c7721dce56247b94c?el=desc) (25c5b09) will **decrease** coverage by `8.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 68.92% 59.99% -8.93%
==========================================
Files 48 48
Lines 3047 3047
==========================================
- Hits 2100 1828 -272
- Misses 707 976 +269
- Partials 240 243 +3
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-28.58%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1515/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=footer). Last update [25c5b09...8f9589b](https://codecov.io/gh/apache/apisix-dashboard/pull/1515?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1515: test: front-end e2e test for rawDataEditor
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1515:
URL: https://github.com/apache/apisix-dashboard/pull/1515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org