You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/17 08:52:58 UTC

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9381: Expose ReachedEndOfTopic in Reader/Consumer API

MarvinCai commented on a change in pull request #9381:
URL: https://github.com/apache/pulsar/pull/9381#discussion_r577427980



##########
File path: pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java
##########
@@ -84,6 +88,8 @@
     private volatile long msgDeliveredCounter = 0;
     private static final AtomicLongFieldUpdater<ConsumerHandler> MSG_DELIVERED_COUNTER_UPDATER =
             AtomicLongFieldUpdater.newUpdater(ConsumerHandler.class, "msgDeliveredCounter");
+    //default interval for checking if end of topic has been reached is 10 min
+    private static long END_OF_TOPIC_CHECK_INTERVAL = 10 * 60;

Review comment:
       my mistake, was trying to use push mode to notify endOfTopic with periodic check, probably can add that later.
   removed it for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org