You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/07/24 22:39:14 UTC
[jira] Created: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
setdata on root (/) crashes the servers.
----------------------------------------
Key: ZOOKEEPER-487
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
Project: Zookeeper
Issue Type: Bug
Components: server
Affects Versions: 3.2.0, 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
Fix For: 3.2.1, 3.3.0
setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
{code}
java.lang.IllegalArgumentException: Invalid path /
at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-487:
------------------------------------
Status: Patch Available (was: Open)
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737603#action_12737603 ]
Hadoop QA commented on ZOOKEEPER-487:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12414474/ZOOKEEPER-487.patch
against trunk revision 799460.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/162/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/162/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/162/console
This message is automatically generated.
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-487:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Looks good Mahadev, +1. thanks.
Committed revision 799702.
Committed revision 799703.
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737862#action_12737862 ]
Hudson commented on ZOOKEEPER-487:
----------------------------------
Integrated in ZooKeeper-trunk #401 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/401/])
. setdata on root (/) crashes the servers
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-487:
------------------------------------
Attachment: ZOOKEEPER-487.patch
this patch fixes the issue and includes test for setting data on "/".
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-487) setdata on root (/) crashes the
servers.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735222#action_12735222 ]
Patrick Hunt commented on ZOOKEEPER-487:
----------------------------------------
Wow, this sucks. :-) Good catch.
Re a 3.1.2, since this is deterministic, and the first anyone has noticed, I think we should be
safe saying prior to 3.2.1 "don't set data on / znode" and leave it at that. It's pretty
atypical anyway and should be easy to work around - set "/root" (whatever) instead.
> setdata on root (/) crashes the servers.
> ----------------------------------------
>
> Key: ZOOKEEPER-487
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-487
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-487.patch
>
>
> setdata on root "/" crashes the servers with the followimg exception. Unfortunately we never had a setdata test on root. The following is the exception. This happens with 3.1.1 as well. We might want to consider releasing 3.1.2 just for this jira.
> {code}
> java.lang.IllegalArgumentException: Invalid path /
> at org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:255)
> at org.apache.zookeeper.server.DataTree.setData(DataTree.java:543)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:701)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:94)
> at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
> at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.