You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/03 01:39:57 UTC

[GitHub] [skywalking] hanahmily opened a new issue, #9902: Metadata registration bugs

hanahmily opened a new issue, #9902:
URL: https://github.com/apache/skywalking/issues/9902

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   There are some tiny bugs related to the metadata registration:
   
     * Lack of checking the group existed when applying a property.
     * The update time is absent when creating schemas.
     * Some required fields lack validations when creating schemas.
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily commented on issue #9902: Metadata registration bugs

Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #9902:
URL: https://github.com/apache/skywalking/issues/9902#issuecomment-1384753827

   `property.proto` checking rules:
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/property/v1/property.proto#L30
   
   All fields are required.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/property/v1/property.proto#L38
   
   All fields are required except for `updated_at`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily closed issue #9902: Metadata registration bugs

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily closed issue #9902: Metadata registration bugs
URL: https://github.com/apache/skywalking/issues/9902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily commented on issue #9902: Metadata registration bugs

Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #9902:
URL: https://github.com/apache/skywalking/issues/9902#issuecomment-1384751915

   There are some check rules for `schema.proto`
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L39
   
   * `name` is required
   * `tags` contains one item at least
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L45
   
   `name` and `type` are required.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L55
   
   All fields are required except for `updated_at `
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L67
   
   There are one item at least
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L89
   
   All fields are required.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L101
   
   All fields are required expect for `interval`, `fields` and `updated_at`.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L118
   
   `metadata`, `source_measure ` and `field_name` are required.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L144
   
   All fields are required except for `analyzer` and `updated_at`.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L184
   
   All fields are required.
   
   ## https://github.com/apache/skywalking-banyandb/blob/main/api/proto/banyandb/database/v1/schema.proto#L194
   
   All fields are required except for `updated_at`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] HHoflittlefish777 commented on issue #9902: Metadata registration bugs

Posted by GitBox <gi...@apache.org>.
HHoflittlefish777 commented on issue #9902:
URL: https://github.com/apache/skywalking/issues/9902#issuecomment-1364809564

   please assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org