You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/18 08:26:14 UTC

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #6648: [IOTDB-3475] Fix ResultSet format for empty query

JackieTien97 commented on code in PR #6648:
URL: https://github.com/apache/iotdb/pull/6648#discussion_r923084456


##########
server/src/main/java/org/apache/iotdb/db/utils/QueryDataSetUtils.java:
##########
@@ -202,6 +202,10 @@ public static TSQueryDataSet convertTsBlockByFetchSize(
         break;
       }
       TsBlock tsBlock = optionalTsBlock.get();
+      if (tsBlock.isEmpty()) {
+        break;
+      }

Review Comment:
   We cannot simply break here, there is no guarantee that tsBlock won't be empty. If it's really finished, optionalTsBlock.isPresent() will return false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org