You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/10/18 00:55:34 UTC
Review Request 26897: Support lxc configurations in docker info
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26897/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Support lxc configurations in docker info
Diffs
-----
include/mesos/mesos.proto 6b93e90
src/docker/docker.cpp e09b51c
Diff: https://reviews.apache.org/r/26897/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26897: Support lxc configurations in docker info
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26897/#review59401
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto
<https://reviews.apache.org/r/26897/#comment100669>
Let's just have a 'repeated Parameter parameters = 5' with a comment that explains that we'll pass these as --key=value to the CLI but that this functionality is not guaranteed depending on whether or not we use a different Docker "backend" (e.g., the Docker REST interface instead of the CLI).
src/docker/docker.cpp
<https://reviews.apache.org/r/26897/#comment100667>
s/param/parameter/
- Benjamin Hindman
On Oct. 29, 2014, 12:23 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26897/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 12:23 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Support lxc configurations in docker info
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 168a7a8
> src/docker/docker.cpp 9973782
>
> Diff: https://reviews.apache.org/r/26897/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26897: Support lxc configurations in docker info
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26897/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 12:23 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Support lxc configurations in docker info
Diffs (updated)
-----
include/mesos/mesos.proto 168a7a8
src/docker/docker.cpp 9973782
Diff: https://reviews.apache.org/r/26897/diff/
Testing
-------
make check
Thanks,
Timothy Chen