Re: [PR] HDDS-9199. Snapshot chain corruption should not fail OM restart [ozone]

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #5262:
URL: https://github.com/apache/ozone/pull/5262#discussion_r1345886082


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -298,7 +298,7 @@ private void removeSnapshotInfoFromSnapshotChainManager(
   ) {
     try {
       snapshotChainManager.deleteSnapshot(info);
-    } catch (IOException exception) {
+    } catch (IllegalStateException exception) {
       LOG.error("Failed to remove snapshot: {} from SnapshotChainManager.",
           info, exception);
     }

Review Comment:
   Is it intended that this exception is swallowed here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org