[GitHub] [airflow] uranusjr commented on a change in pull request #15112: Avoid scheduler/parser manager deadlock by using non-blocking IO

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #15112:
URL: https://github.com/apache/airflow/pull/15112#discussion_r605046059



##########
File path: airflow/utils/dag_processing.py
##########
@@ -696,11 +706,20 @@ def _run_parsing_loop(self):
             max_runs_reached = self.max_runs_reached()
 
             dag_parsing_stat = DagParsingStat(
-                self._file_paths,
+                len(self._file_paths),
                 max_runs_reached,
                 all_files_processed,
             )
-            self._signal_conn.send(dag_parsing_stat)
+            try:
+                self._signal_conn.send(dag_parsing_stat)

Review comment:
       It wouldn't be a bad idea to add a timeout, but that's extremely rarely an issue for local sockets (things need to get pretty wrong for that to happen at all). This can always be revisited if someone ever complains.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org