You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2026/03/31 09:55:59 UTC
[PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
dataroaring opened a new pull request, #61942:
URL: https://github.com/apache/doris/pull/61942
## Summary
Cherry-pick of #61845 to `branch-4.0`.
- Changed `auto_partition_near_limit_count` and `dynamic_partition_near_limit_count` from `LongCounterMetric` (monotonically increasing) to `GaugeMetricImpl<Long>` so they correctly decrease when the near-limit condition resolves
- Moved metric computation from inline event-driven increments (in `FrontendServiceImpl` and `DynamicPartitionUtil`) to `TabletStatMgr`'s periodic all-table scan, which already iterates all tables and partitions under read locks
- Metric names are preserved for monitoring compatibility; semantics changed from "cumulative event count" to "current number of tables near the limit"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #61942:
URL: https://github.com/apache/doris/pull/61942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61942:
URL: https://github.com/apache/doris/pull/61942#issuecomment-4162173096
# FE UT Coverage Report
Increment line coverage ` 38.24% (13/34)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61942_03725d89d95386ac31a50ab48838739bb9cdf1f0/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61942_03725d89d95386ac31a50ab48838739bb9cdf1f0/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61942:
URL: https://github.com/apache/doris/pull/61942#issuecomment-4161790340
# FE UT Coverage Report
Increment line coverage ` 38.24% (13/34)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61942_c8dedaba7c5754aa5f494745b45dc920d7c100b6/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61942_c8dedaba7c5754aa5f494745b45dc920d7c100b6/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #61942:
URL: https://github.com/apache/doris/pull/61942#discussion_r3014863179
##########
fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java:
##########
@@ -1006,15 +1006,16 @@ public Integer getValue() {
GAUGE_AVG_TABLET_SIZE_BYTES = new GaugeMetricImpl<>("avg_tablet_size_bytes", MetricUnit.BYTES, "", 0L);
DORIS_METRIC_REGISTER.addMetrics(GAUGE_AVG_TABLET_SIZE_BYTES);
- // Partition near-limit warning counters
- COUNTER_AUTO_PARTITION_NEAR_LIMIT = new LongCounterMetric("auto_partition_near_limit_count",
+ // Partition near-limit warning gauges (updated by TabletStatMgr periodic scan)
Review Comment:
The comment says these gauges are updated by `TabletStatMgr` periodic scan, but they are also updated by `CloudTabletStatMgr` in cloud mode. Update the comment to reflect both update paths (or a more generic “updated by *TabletStatMgr/CloudTabletStatMgr* periodic scan”) so it stays accurate.
```suggestion
// Partition near-limit warning gauges (updated by TabletStatMgr/CloudTabletStatMgr periodic scans)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #61942:
URL: https://github.com/apache/doris/pull/61942#issuecomment-4161703489
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61942:
URL: https://github.com/apache/doris/pull/61942#issuecomment-4161395800
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Change partition near-limit metrics from counters to gauges (#61845) [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #61942:
URL: https://github.com/apache/doris/pull/61942#issuecomment-4161399939
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org