You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2016/07/15 07:25:17 UTC

[GitHub] spark pull request #14210: [SPARK-16556] [SPARK-16559] [SQL] Fix Two Bugs in...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14210#discussion_r70931496
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala ---
    @@ -75,7 +75,14 @@ private[sql] case class InsertIntoHadoopFsRelationCommand(
             case (x, ys) if ys.length > 1 => "\"" + x + "\""
           }.mkString(", ")
           throw new AnalysisException(s"Duplicate column(s) : $duplicateColumns found, " +
    -          s"cannot save to file.")
    +        "cannot save to file.")
    +    }
    +
    +    bucketSpec.foreach { spec =>
    --- End diff --
    
    ```
    if (bucketSpec.exists(_.numBuckets <= 0)) {
      ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org