You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zhipeng93 (via GitHub)" <gi...@apache.org> on 2023/03/06 03:42:09 UTC

[GitHub] [flink-ml] zhipeng93 commented on pull request #220: [FLINK-31325] Improve performance of Swing.

zhipeng93 commented on PR #220:
URL: https://github.com/apache/flink-ml/pull/220#issuecomment-1455393210

   Thanks for the PR. Can you update the PR description as follows for better readbility?
   
   - Remove the `dot` at the end of PR title. The PR titles usually do not end with `.`.
   - Add more detailed description about the performance improvement. For example, (1) the dataset used (2) the parameter settings of Swing (3) the detail performance improvement.
   - It seems that this PR introduces `HasSeed` param for Swing. Please add it in the change log and explain why do we add it here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org