[GitHub] [arrow] pitrou commented on a change in pull request #7233: ARROW-8860: [C++] Fix IPC/Feather decompression for nested types (with child_data)

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7233:
URL: https://github.com/apache/arrow/pull/7233#discussion_r428583079



##########
File path: python/pyarrow/tests/test_feather.py
##########
@@ -753,3 +760,18 @@ def test_read_column_duplicated_in_file(tempdir):
     # selection with column names errors
     with pytest.raises(ValueError):
         read_table(path, columns=['a', 'b'])
+
+
+def test_nested_types(compression):
+    # https://issues.apache.org/jira/browse/ARROW-8860
+    table = pa.table({'col': pa.StructArray.from_arrays(
+        [[0, 1, 2], [1, 2, 3]], names=["f1", "f2"])})
+    _check_arrow_roundtrip(table, compression=compression)
+
+    table = pa.table({'col': pa.array([[1, 2], [3, 4]])})
+    _check_arrow_roundtrip(table, compression=compression)
+
+
+@h.given(past.all_tables)
+def test_roundtrip(table):
+    _check_arrow_roundtrip(table)

Review comment:
       Should this test different compressions as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org