jhutchison opened a new pull request #6239:
URL: https://github.com/apache/geode/pull/6239
- make readme commands an unordered list
- remove text related to unsupported commands in readme
- alphabetize list of commands in SupportedCommands Junit Test for easy comparison
- remove references to unsupported commands from docs page
- remove duplicate server category in RedisCommandType
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Docs team is added as reviewers here. FYI, we're starting to make PRs that only include docs changes related to a specific corresponding feature/code change PR to help with flow (ask me if you want more detail- the intent is to free up PRs from waiting for doc team availability, while keeping them tied to specific code changes ). John didn't indicate any desire to review the PR, but he is aware of the changes. I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
davebarnes97 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606368257
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
Review comment:
Same as above: drop "currently"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606287088
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
Review comment:
and since we are already using a superscript for slowlog, I would assume another superscript for INFO (as opposed to asterick)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607232193
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
Review comment:
thx- changes made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607235814
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
Review comment:
thanks- changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607218621
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
-**Note**: These commands are supported for Redis 5.
-**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
-
-- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
-- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL,
- TYPE
-- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Server**: SLOWLOG, INFO
-- **Sets**: SADD, SMEMBERS, SREM
-- **Strings**: APPEND, DECR, DECRBY, GET, GETRANGE, INCR, INCRBY, INCRBYFLOAT, MGET, SET, SETNX, STRLEN
-
-The following Redis commands are **unsupported** by <%=vars.produce_name%>'s APIs compatible with Redis. Unsupported
-commands are available to use, but have not been fully tested. There is no guarantee they will work
-exactly as expected.
-
-- **Connection**: ECHO, SELECT
-- **Keys**: SCAN, UNLINK
-- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
-- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
- SSCAN, SUNION, SUNIONSTORE
-- **Strings**: BITCOUNT, BITOP, BITPOS, GETBIT, GETSET, MSET, MSETNX, PSETEX, SETBIT, SETEX, SETRANGE
-
-
-If you already have some Geode servers running that are compatible with Redis, you can execute the
-following command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
+Commands not listed above are **not implemented**.
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<compatibleWithRedisPort> \
- --compatible-with-redis-bind-address=<compatibleWithRedisBindAddress> \
- --compatible-with-redis-password=<compatibleWithRedisPassword>
-```
+**Note**: These commands are supported for Redis 5.
-Commands not listed above are **not implemented**.
+**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
Review comment:
Since we added the superscript in the list above, should we add it here as well?
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
Review comment:
However we ultimately decide to format the `INFO` note, could we also add it to the Notes section below the commands in `geode_apis_compatible_with_redis.html.md.erb`?
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
Review comment:
Not sure if we want to mention that it will return `keys`, but `expires` and `avg_ttl` will always be 0? Also, it seems to be referenced in Redis docs and the keyspace section as `db0`.
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
+ - memory
+ - maxmemory
+ - used_memory
+ - mem_fragmentation_ratio (will always report 1.00)
+ - persistence
+ - loading (will always return 0)
+ - rdb_changes_since_last_save (will always return 0)
+ - rdb_last_save_time (will always return 0)
+ - replication
+ - role
Review comment:
Right now this is always `master`.
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
+ - memory
+ - maxmemory
+ - used_memory
+ - mem_fragmentation_ratio (will always report 1.00)
+ - persistence
+ - loading (will always return 0)
+ - rdb_changes_since_last_save (will always return 0)
+ - rdb_last_save_time (will always return 0)
+ - replication
+ - role
+ - connected_slaves (will always return 0)
+ - server
+ - redis_version
+ - redis_mode
Review comment:
This is always `standalone` right now... not sure if we need to say that or not?
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
Review comment:
I think this is `cluster_enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
davebarnes97 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606367693
##########
File path: geode-redis/README.md
##########
@@ -25,7 +25,7 @@ and then connect the [Redis-CLI](https://redis.io/topics/quickstart) to that ins
### <a name="building-apache-geode"></a>Supported Redis Commands
-Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#redis-command-status).
+Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#supported-redis-commands).
Review comment:
Please do not say "currently", as it constitutes a promise for future updates that makes the product sound half-baked and unstable. Just say "Not all Redis commands are supported."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Docs team is added as reviewers here. FYI, we're starting to make PRs that only include docs changes related to specific corresponding feature/code change PR to help with flow (ask me if you want more detail). John didn't indicate any desire to review the PR, but he is aware of the changes. I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605754623
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
This should be:
```
The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
```
Somehow `Redis` got removed and `implements` should be `implement` since APIs is plural (this is the convention we've been following, but this must've gotten overlooked when it was originally changed).
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
Review comment:
Somehow the following commands got left out:
```
APPEND
AUTH
DECR
DECRBY
DEL
EXISTS
```
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+<sup>1</sup> SLOWLOG is implemented as a NoOp.
Review comment:
I like the superscript! You could put `<br>` after `NOTES` so that the note is on the next line (rather than on the same line as `NOTES`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r608871545
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
Review comment:
you are right- thanks for catching it again! should be there now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606285967
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
Review comment:
I can add- is there an agreed upon existing verbage? or should I just write one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607225571
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
Review comment:
yes- thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605961589
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
I apologize, I thought I made this comment in the previous review, but it looks like it wasn't saved somehow. Could we make this title `Supported Redis Commands` to be consistent with the docs and since we are talking about actual Redis commands vs. something we created (a decision we made in [this PR](https://github.com/apache/geode/pull/6150). Then the link name could potentially change from `redis-command-status` to `supported-commands` (there is a reference to this section in a prior section of the README that will also need to change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
davebarnes97 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607205133
##########
File path: geode-redis/README.md
##########
@@ -25,7 +25,7 @@ and then connect the [Redis-CLI](https://redis.io/topics/quickstart) to that ins
### <a name="building-apache-geode"></a>Supported Redis Commands
-Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#redis-command-status).
+Not all Redis commands are supported. The current set of supported Redis commands is listed [here](#supported-redis-commands).
Review comment:
An occurrence of 'current' remains. Suggested re-wording:
Not all Redis commands are supported. See [Supported Redis Commands](#supported-redis-commands) for the implemented subset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605754623
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
This should be:
```
The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
```
Somehow `Redis` got removed and `implements` should be `implement` since APIs is plural (this is the convention we've been following, but this must've gotten overlooked when it was originally changed). There are other places in the README where this needs to be fixed, but that could be a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605822824
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+<sup>1</sup> SLOWLOG is implemented as a NoOp.
Review comment:
sure. added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Docs team is added as reviewers here. FYI, we're starting to make PRs that only include docs changes related to a specific corresponding feature/code change PR to help with flow (ask me if you want more detail). John didn't indicate any desire to review the PR, but he is aware of the changes. I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607227643
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
+ - memory
+ - maxmemory
+ - used_memory
+ - mem_fragmentation_ratio (will always report 1.00)
+ - persistence
+ - loading (will always return 0)
+ - rdb_changes_since_last_save (will always return 0)
+ - rdb_last_save_time (will always return 0)
+ - replication
+ - role
+ - connected_slaves (will always return 0)
+ - server
+ - redis_version
+ - redis_mode
Review comment:
yeah, I wasn't sure how far to go with saying what is hardcoded, but I guess it makes to be consistent and do it for all hard-coded values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605822096
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
changed, thanks (also added the plural/singular thing to another final check story)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605776359
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+<sup>1</sup> SLOWLOG is implemented as a NoOp.
Review comment:
I like the superscript! You could put `<br>` after `NOTES` so that the note is on the next line (rather than on the same line as `NOTES`) (check out the README preview in IntelliJ or GitHub's `Display the rich diff`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
nonbinaryprogrammer commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607195192
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
Review comment:
since APIs is plural, supports -> support
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
-**Note**: These commands are supported for Redis 5.
-**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
-
-- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
-- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL,
- TYPE
-- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Server**: SLOWLOG, INFO
-- **Sets**: SADD, SMEMBERS, SREM
-- **Strings**: APPEND, DECR, DECRBY, GET, GETRANGE, INCR, INCRBY, INCRBYFLOAT, MGET, SET, SETNX, STRLEN
-
-The following Redis commands are **unsupported** by <%=vars.produce_name%>'s APIs compatible with Redis. Unsupported
-commands are available to use, but have not been fully tested. There is no guarantee they will work
-exactly as expected.
-
-- **Connection**: ECHO, SELECT
-- **Keys**: SCAN, UNLINK
-- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
-- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
- SSCAN, SUNION, SUNIONSTORE
-- **Strings**: BITCOUNT, BITOP, BITPOS, GETBIT, GETSET, MSET, MSETNX, PSETEX, SETBIT, SETEX, SETRANGE
-
-
-If you already have some Geode servers running that are compatible with Redis, you can execute the
-following command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
+Commands not listed above are **not implemented**.
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<compatibleWithRedisPort> \
- --compatible-with-redis-bind-address=<compatibleWithRedisBindAddress> \
- --compatible-with-redis-password=<compatibleWithRedisPassword>
-```
+**Note**: These commands are supported for Redis 5.
-Commands not listed above are **not implemented**.
+**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
Review comment:
you put 1 as a superscript for the slowlog command but didn't reference [1] here. Also @sabbey37 informed me that @karensmolermiller said in a PR:
```
If there will be more notes about specific commands, I'd like to see the notes placed next to the
command within the lists. Maybe add the note in parenthesis? I believe that documentation readers are
more likely to see the note if it is with the command, as I believe that readers will be likely to scan
this page for the commands that they use. I don't think they'll be starting at the top to do a detailed
reading.
```
so this might be a good time to move the note next to the command in the list
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
-**Note**: These commands are supported for Redis 5.
-**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
-
-- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
-- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL,
- TYPE
-- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Server**: SLOWLOG, INFO
-- **Sets**: SADD, SMEMBERS, SREM
-- **Strings**: APPEND, DECR, DECRBY, GET, GETRANGE, INCR, INCRBY, INCRBYFLOAT, MGET, SET, SETNX, STRLEN
-
-The following Redis commands are **unsupported** by <%=vars.produce_name%>'s APIs compatible with Redis. Unsupported
-commands are available to use, but have not been fully tested. There is no guarantee they will work
-exactly as expected.
-
-- **Connection**: ECHO, SELECT
-- **Keys**: SCAN, UNLINK
-- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
-- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
- SSCAN, SUNION, SUNIONSTORE
-- **Strings**: BITCOUNT, BITOP, BITPOS, GETBIT, GETSET, MSET, MSETNX, PSETEX, SETBIT, SETEX, SETRANGE
-
-
-If you already have some Geode servers running that are compatible with Redis, you can execute the
-following command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
+Commands not listed above are **not implemented**.
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<compatibleWithRedisPort> \
- --compatible-with-redis-bind-address=<compatibleWithRedisBindAddress> \
- --compatible-with-redis-password=<compatibleWithRedisPassword>
-```
+**Note**: These commands are supported for Redis 5.
-Commands not listed above are **not implemented**.
+**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
Review comment:
based on our synchronous discussion:
one solution that would allow us to put the notes inline with the commands would be to bold the commands and have the note as a line or paragraph after the bolded text. so it would look like:
- **SETNX**
- **SLOWLOG** - SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools
- **SMEMBERS**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605776359
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+<sup>1</sup> SLOWLOG is implemented as a NoOp.
Review comment:
I like the superscript! You could put `<br>` after `NOTES` so that the note is on the next line (rather than on the same line as `NOTES`) (check out the README preview in IntelliJ or GitHub's `Display rich diff`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605962580
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
Review comment:
There are also a couple notes we have in the docs around supported commands. I am not sure if we want to add them here (or maybe remove them from the docs?) Specifically these two:
- `Commands not listed above are **not implemented**.` (this is at the end of the Supported Commands section)
- `**Note**: These commands are supported for Redis 5.` (at the beginning of the Supported Commands section)
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
I apologize, I thought I made this comment in the previous review, but it looks like it wasn't made somehow. Could we make this title `Supported Redis Commands` to be consistent with the docs and since we are talking about actual Redis commands vs. something we created (a decision we made in [this PR](https://github.com/apache/geode/pull/6150). Then the link name could potentially change from `redis-command-status` to `supported-commands` (there is a reference to this section in a prior section of the README that will also need to change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Yeah, docs team. are added as reviewers here. FYI, we're starting to make PR's that only include docs changes related to specific corresponding feature/code change PR to help with flow. John didn't indicate any desire to review the PR, but I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
nonbinaryprogrammer commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r608828552
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
Review comment:
hey, @jhutchison, it looks like this didn't get changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
davebarnes97 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607205133
##########
File path: geode-redis/README.md
##########
@@ -25,7 +25,7 @@ and then connect the [Redis-CLI](https://redis.io/topics/quickstart) to that ins
### <a name="building-apache-geode"></a>Supported Redis Commands
-Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#redis-command-status).
+Not all Redis commands are supported. The current set of supported Redis commands is listed [here](#supported-redis-commands).
Review comment:
An occurrence of 'current' remains. Suggested re-wording:
Not all Redis commands are supported. See [Supported Redis Commands](#supported-redis-commands).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607228403
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
+ - memory
+ - maxmemory
+ - used_memory
+ - mem_fragmentation_ratio (will always report 1.00)
+ - persistence
+ - loading (will always return 0)
+ - rdb_changes_since_last_save (will always return 0)
+ - rdb_last_save_time (will always return 0)
+ - replication
+ - role
Review comment:
same as below (will change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jdeppe-pivotal merged pull request #6239: URL: https://github.com/apache/geode/pull/6239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Yeah, docs team. are added as reviewers here. FYI, we're starting to make PRs that only include docs changes related to specific corresponding feature/code change PR to help with flow (ask me if you want more detail). John didn't indicate any desire to review the PR, but he is aware of the changes. I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606264015
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
Review comment:
I'm not sure what we want to do about those- I'll add them to the final check story
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605754623
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
This should be:
```
The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
```
Somehow `Redis` got removed and `implements` should be `implement` since APIs is plural (this is the convention we've been following, but this must've gotten overlooked when it was originally changed). There are other places in the README/docs where this needs to be fixed, but that could be a different PR. [More info on this decision/convention can be found in [this PR](https://github.com/apache/geode/pull/6150), specifically in John Martin's review comments.
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
This should be:
```
The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
```
Somehow `Redis` got removed and `implements` should be `implement` since APIs is plural (this is the convention we've been following, but this must've gotten overlooked when it was originally changed). There are other places in the README/docs where this needs to be fixed, but that could be a different PR. [More info on this decision/convention can be found in [this PR](https://github.com/apache/geode/pull/6150), specifically in John Martin's review comments.]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606269669
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> Sorry, a couple of additional changes that seemed not to have been saved in the last review. Also, will there be some final review by the docs team and John Martin?
Yeah, docs team. are added as reviewers here. FYI, we're starting to make PRs that only include docs changes related to specific corresponding feature/code change PR to help with flow (ask me if you want more detail). John didn't indicate any desire to review the PR, but I'll make sure he knows that it's here if he wants to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607126834
##########
File path: geode-redis/README.md
##########
@@ -25,7 +25,7 @@ and then connect the [Redis-CLI](https://redis.io/topics/quickstart) to that ins
### <a name="building-apache-geode"></a>Supported Redis Commands
-Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#redis-command-status).
+Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#supported-redis-commands).
Review comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
davebarnes97 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607205133
##########
File path: geode-redis/README.md
##########
@@ -25,7 +25,7 @@ and then connect the [Redis-CLI](https://redis.io/topics/quickstart) to that ins
### <a name="building-apache-geode"></a>Supported Redis Commands
-Not all Redis commands are currently supported. The current set of supported Redis commands is listed [here](#redis-command-status).
+Not all Redis commands are supported. The current set of supported Redis commands is listed [here](#supported-redis-commands).
Review comment:
An occurrence of 'current' remains. Suggested re-wording:
Not all Redis commands are supported. See [Supported Redis Commands](#supported-redis-commands) for the implemented subset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605822272
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
+- EXPIRE
Review comment:
wow- not sure how that happened- thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607232193
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
Review comment:
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606278100
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="redis-command-status"></a> Supported Commands Compatable With Redis [Return to top](#introduction)
Review comment:
> I apologize, I thought I made this comment in the previous review, but it looks like it wasn't saved somehow. Could we make this title `Supported Redis Commands` to be consistent with the docs and since we are talking about actual Redis commands vs. something we created (a decision we made in [this PR](https://github.com/apache/geode/pull/6150). Then the link name could potentially change from `redis-command-status` to `supported-commands` (there is a reference to this section in a prior section of the README that will also need to change).
made changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607228403
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
+ - clients
+ - connected_clients
+ - blocked_clients (will always return 0)
+ - cluster
+ - cluster_enables (will always return 0)
+ - keyspace
+ - returns stats for db: 0
+ - memory
+ - maxmemory
+ - used_memory
+ - mem_fragmentation_ratio (will always report 1.00)
+ - persistence
+ - loading (will always return 0)
+ - rdb_changes_since_last_save (will always return 0)
+ - rdb_last_save_time (will always return 0)
+ - replication
+ - role
Review comment:
same as below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607225325
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,98 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO <sup>1</sup>
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>2</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
+
+**NOTES:** <br/>
+<sup>1</sup> INFO is implemented for the sections and fields listed below:
Review comment:
yes. we will, for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607127090
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605754623
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
This should be:
```
The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
```
Somehow `Redis` got removed and `implements` should be `implement` since APIs is plural (this is the convention we've been following, but this must've gotten overlooked when it was originally changed). There are other places in the README/docs where this needs to be fixed, but that could be a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r605822096
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,55 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
+The Geode APIs compatible with currently implements a subset of the full Redis command set.
Review comment:
changed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607235814
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
Review comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607237226
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
-**Note**: These commands are supported for Redis 5.
-**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
-
-- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
-- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL,
- TYPE
-- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Server**: SLOWLOG, INFO
-- **Sets**: SADD, SMEMBERS, SREM
-- **Strings**: APPEND, DECR, DECRBY, GET, GETRANGE, INCR, INCRBY, INCRBYFLOAT, MGET, SET, SETNX, STRLEN
-
-The following Redis commands are **unsupported** by <%=vars.produce_name%>'s APIs compatible with Redis. Unsupported
-commands are available to use, but have not been fully tested. There is no guarantee they will work
-exactly as expected.
-
-- **Connection**: ECHO, SELECT
-- **Keys**: SCAN, UNLINK
-- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
-- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
- SSCAN, SUNION, SUNIONSTORE
-- **Strings**: BITCOUNT, BITOP, BITPOS, GETBIT, GETSET, MSET, MSETNX, PSETEX, SETBIT, SETEX, SETRANGE
-
-
-If you already have some Geode servers running that are compatible with Redis, you can execute the
-following command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
+Commands not listed above are **not implemented**.
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<compatibleWithRedisPort> \
- --compatible-with-redis-bind-address=<compatibleWithRedisBindAddress> \
- --compatible-with-redis-password=<compatibleWithRedisPassword>
-```
+**Note**: These commands are supported for Redis 5.
-Commands not listed above are **not implemented**.
+**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
Review comment:
as per convo, lets wait to see how long info shakes out to be when all reviews are in, and then see if @Kmiller thinks they should all be in-lined, or all be footnotes, or different approaches for different commands/length of notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jomartin-999 commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r606282180
##########
File path: geode-redis/README.md
##########
@@ -128,210 +128,61 @@ not connected>
```
### <a name="redis-commands"></a>Redis Commands
-The Geode APIs compatible with Redis currently implements a subset of the full Redis command set. Some commands
-are **unsupported** (see table below). Unsupported commands are available to use, but have not been
-fully tested. There is no guarantee they will work exactly as expected.
-
-#### <a name="enable-unsupported-commands"></a>Enabling Unsupported Commands
-
-If you already have Geode servers running with Redis enabled, you can execute the following
-command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
-
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<redisPort> \
- --compatible-with-redis-bind-address=<redisBindAddress> \
- --compatible-with-redis-password=<redisPassword>
-```
-
-#### <a name="redis-command-status"></a>Redis Command Status [Return to top](#introduction)
-
-| Supported Commands | Unsupported Commands<br>(Implemented - not tested) | Commands Not Implemented |
-|-----------------------|-------------------------------------------------------|-----------------------------------|
-| APPEND | BITCOUNT | ACL CAT |
-| AUTH | BITOP | ACL DELUSER |
-| DECRBY | BITPOS | ACL GENPASS |
-| DEL | DBSIZE | ACL GETUSER |
-| EXISTS | DECR | ACL HELP |
-| EXPIRE | ECHO | ACL LIST |
-| EXPIREAT | FLUSHALL | ACL LOAD |
-| GET | FLUSHDB | ACL LOG |
-| HGETALL | GETBIT | ACL SAVE |
-| HMGET | GETRANGE | ACL SETUSER |
-| HMSET | GETSET | ACL USERS |
-| HSET | HDEL | ACL WHOAMI |
-| HSETNX | HEXISTS | BGREWRITEAOF |
-| HSTRLEN | HGET | BGSAVE |
-| HLEN | HINCRBY | BITFIELD |
-| HVALS | HINCRBYFLOAT | BLPOP |
-| INFO | HKEYS | BRPOP |
-| KEYS | HSCAN | BRPOPLPUSH |
-| PERSIST | INCR | BZPOPMAX |
-| PEXPIRE | INCRBY | BZPOPMIN |
-| PEXPIREAT | INCRBYFLOAT | CLIENT CACHING |
-| PING | MGET | CLIENT GETNAME |
-| PSUBSCRIBE | MSET | CLIENT ID |
-| PTTL | MSETNX | CLIENT KILL |
-| PUNSUBSCRIBE | PSETEX | CLIENT LIST |
-| QUIT | SCAN | CLIENT PAUSE |
-| RENAME | SCARD | CLIENT REPLY |
-| SADD | SDIFF | CLIENT SETNAME |
-| SET | SDIFFSTORE | CLIENT TRACKING |
-| SLOWLOG[2] | SELECT | CLIENT UNBLOCK |
-| SMEMBERS | SETBIT | CLUSTER ADDSLOTS |
-| SREM | SETEX | CLUSTER BUMPEPOCH |
-| SUBSCRIBE | SETNX | CLUSTER COUNT-FAILURE-REPORTS |
-| TTL | SETRANGE | CLUSTER COUNTKEYSINSLOT |
-| TYPE | SHUTDOWN | CLUSTER DELSLOTS |
-| UNSUBSCRIBE | SINTER | CLUSTER FAILOVER |
-| PUBLISH | SINTERSTORE | CLUSTER FLUSHSLOTS |
-| | SISMEMBER | CLUSTER FORGET |
-| | SLOWLOG | CLUSTER GETKEYSINSLOT |
-| | SMOVE | CLUSTER INFO |
-| | SPOP | CLUSTER KEYSLOT |
-| | SRANDMEMBER | CLUSTER MEET |
-| | SSCAN | CLUSTER MYID |
-| | STRLEN | CLUSTER NODES |
-| | SUNION | CLUSTER REPLICAS |
-| | SUNIONSTORE | CLUSTER REPLICATE |
-| | TIME | CLUSTER RESET |
-| | UNLINK [1] | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
-| | | CLIENT GETREDIR |
-| | | CLUSTER SLAVES |
-| | | CLUSTER SLOTS |
-| | | COMMAND |
-| | | COMMAND COUNT |
-| | | COMMAND GETKEYS |
-| | | COMMAND INFO |
-| | | CONFIG GET |
-| | | CONFIG RESETSTAT |
-| | | CONFIG REWRITE |
-| | | CONFIG SET |
-| | | DEBUG OBJECT |
-| | | DEBUG SEGFAULT |
-| | | DISCARD |
-| | | DUMP |
-| | | EVAL |
-| | | EVALSHA |
-| | | EXEC |
-| | | GEOADD |
-| | | GEODIST |
-| | | GEOHASH |
-| | | GEOPOS |
-| | | GEORADIUS |
-| | | GEORADIUSBYMEMBER |
-| | | LASTSAVE |
-| | | LATENCY DOCTOR |
-| | | LATENCY GRAPH |
-| | | LATENCY HELP |
-| | | LATENCY HISTORY |
-| | | LATENCY LATEST |
-| | | LATENCY RESET |
-| | | LINDEX |
-| | | LINSERT |
-| | | LLEN |
-| | | LOLWUT |
-| | | LPOP |
-| | | LPOS |
-| | | LPUSH |
-| | | LPUSHX |
-| | | LRANGE |
-| | | LREM |
-| | | LSET |
-| | | LTRIM |
-| | | MEMORY DOCTOR |
-| | | MEMORY HELP |
-| | | MEMORY MALLOC-STATS |
-| | | MEMORY PURGE |
-| | | MEMORY STATS |
-| | | MEMORY USAGE |
-| | | MIGRATE |
-| | | MODULE LIST |
-| | | MODULE LOAD |
-| | | MODULE UNLOAD |
-| | | MONITOR |
-| | | MOVE |
-| | | MULTI |
-| | | OBJECT |
-| | | PFADD |
-| | | PFCOUNT |
-| | | PFMERGE |
-| | | PSYNC |
-| | | PUBSUB |
-| | | RANDOMKEY |
-| | | READONLY |
-| | | READWRITE |
-| | | RENAMENX |
-| | | REPLICAOF |
-| | | RESTORE |
-| | | ROLE |
-| | | RPOP |
-| | | RPOPLPUSH |
-| | | RPUSH |
-| | | RPUSHX |
-| | | SAVE |
-| | | SCRIPT DEBUG |
-| | | SCRIPT EXISTS |
-| | | SCRIPT FLUSH |
-| | | SCRIPT KILL |
-| | | SCRIPT LOAD |
-| | | SLAVEOF |
-| | | SORT |
-| | | STRALGO LCS |
-| | | SWAPDB |
-| | | SYNC |
-| | | TOUCH |
-| | | UNWATCH |
-| | | WAIT |
-| | | WATCH |
-| | | XACK |
-| | | XADD |
-| | | XCLAIM |
-| | | XDEL |
-| | | XGROUP |
-| | | XINFO |
-| | | XLEN |
-| | | XPENDING |
-| | | XRANGE |
-| | | XREAD |
-| | | XREADGROUP GROUP |
-| | | XREVRANGE |
-| | | XTRIM |
-| | | ZADD |
-| | | ZCARD |
-| | | ZCOUNT |
-| | | ZINCRBY |
-| | | ZINTERSTORE |
-| | | ZLEXCOUNT |
-| | | ZPOPMAX |
-| | | ZPOPMIN |
-| | | ZRANGE |
-| | | ZRANGEBYLEX |
-| | | ZRANGEBYSCORE |
-| | | ZRANK |
-| | | ZREM |
-| | | ZREMRANGEBYLEX |
-| | | ZREMRANGEBYRANK |
-| | | ZREMRANGEBYSCORE |
-| | | ZREVRANGE |
-| | | ZREVRANGEBYSCORE |
-| | | ZREVRANK |
-| | | ZSCAN |
-| | | ZSCORE |
-| | | ZUNIONSTORE | |
-
-**NOTES:**
-
-[1] - UNLINK is implemented as a synonym to DEL and does not unlink asynchronously.
-[2] - SLOWLOG is implemented as a NoOp.
+The Geode APIs compatible with Redis currently implement a subset of the full Redis command set.
+
+#### <a name="supported-redis-commands"></a> Supported Redis Commands [Return to top](#introduction)
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
Review comment:
@jhutchison We talked having an '*' next to this one and identifying what INFO information is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6239:
URL: https://github.com/apache/geode/pull/6239#discussion_r607228205
##########
File path: geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
##########
@@ -64,52 +64,65 @@ If the server is functioning properly, you should see a response of `PONG`.
## <a id="supported-commands" class="no-quick-link"></a>Supported Redis Commands
-The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands.
+The <%=vars.product_name%> APIs compatible with Redis currently supports the following Redis commands.
+- APPEND
+- AUTH
+- DECR
+- DECRBY
+- DEL
+- EXISTS
+- EXPIRE
+- EXPIREAT
+- GET
+- GETRANGE
+- HDEL
+- HEXISTS
+- HGET
+- HGETALL
+- HINCRBY
+- HINCRBYFLOAT
+- HLEN
+- HMGET
+- HMSET
+- HSCAN
+- HSET
+- HSETNX
+- HSTRLEN
+- HVALS
+- HKEYS
+- INCR
+- INCRBY
+- INCRBYFLOAT
+- INFO
+- KEYS
+- MGET
+- PERSIST
+- PEXPIRE
+- PEXPIREAT
+- PING
+- PSUBSCRIBE
+- PTTL
+- PUBLISH
+- PUNSUBSCRIBE
+- QUIT
+- RENAME
+- SADD
+- SET
+- SETNX
+- SLOWLOG <sup>1</sup>
+- SMEMBERS
+- SREM
+- STRLEN
+- SUBSCRIBE
+- TTL
+- TYPE
+- UNSUBSCRIBE
-**Note**: These commands are supported for Redis 5.
-**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
-
-- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
-- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL,
- TYPE
-- **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE
-- **Server**: SLOWLOG, INFO
-- **Sets**: SADD, SMEMBERS, SREM
-- **Strings**: APPEND, DECR, DECRBY, GET, GETRANGE, INCR, INCRBY, INCRBYFLOAT, MGET, SET, SETNX, STRLEN
-
-The following Redis commands are **unsupported** by <%=vars.produce_name%>'s APIs compatible with Redis. Unsupported
-commands are available to use, but have not been fully tested. There is no guarantee they will work
-exactly as expected.
-
-- **Connection**: ECHO, SELECT
-- **Keys**: SCAN, UNLINK
-- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME
-- **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER,
- SSCAN, SUNION, SUNIONSTORE
-- **Strings**: BITCOUNT, BITOP, BITPOS, GETBIT, GETSET, MSET, MSETNX, PSETEX, SETBIT, SETEX, SETRANGE
-
-
-If you already have some Geode servers running that are compatible with Redis, you can execute the
-following command with gfsh to enable unsupported commands:
-
-```pre
-redis --enable-unsupported-commands
-```
-
-You can also enable unsupported commands when you start the Geode server by setting the Java property `enable-redis-unsupported-commands=true`:
+Commands not listed above are **not implemented**.
-```pre
-start server \
- --J=-Denable-redis-unsupported-commands=true \
- --name=<serverName> \
- --locators=<locatorPort> \
- --compatible-with-redis-port=<compatibleWithRedisPort> \
- --compatible-with-redis-bind-address=<compatibleWithRedisBindAddress> \
- --compatible-with-redis-password=<compatibleWithRedisPassword>
-```
+**Note**: These commands are supported for Redis 5.
-Commands not listed above are **not implemented**.
+**Note**: SLOWLOG is implemented as a NoOp for compatibility with some monitoring tools.
Review comment:
still figuring out notes will look in the .erb. Hoping they can end up being the same as the readme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org