You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:40:18 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request, #17632: Distsql execution is prohibited within a transaction
jingshanglu opened a new pull request, #17632:
URL: https://github.com/apache/shardingsphere/pull/17632
ref #16777.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #17632: Disallow distsql in a transaction
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #17632:
URL: https://github.com/apache/shardingsphere/pull/17632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #17632: Disallow distsql in a transaction
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #17632:
URL: https://github.com/apache/shardingsphere/pull/17632#issuecomment-1126909095
In addition, `QueryableRALStatement` is also allowed to execute, which suffices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17632: Distsql execution is prohibited within a transaction
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17632:
URL: https://github.com/apache/shardingsphere/pull/17632#issuecomment-1126315902
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17632](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbcb7af) into [master](https://codecov.io/gh/apache/shardingsphere/commit/46c1d05390205ff203fe1d9a9fcd6fe5ad44f2bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46c1d05) will **decrease** coverage by `0.29%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #17632 +/- ##
============================================
- Coverage 59.17% 58.87% -0.30%
- Complexity 2123 2125 +2
============================================
Files 3558 3583 +25
Lines 53025 53376 +351
Branches 9043 9106 +63
============================================
+ Hits 31377 31427 +50
- Misses 19000 19294 +294
- Partials 2648 2655 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ackend/text/TextProtocolBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L1RleHRQcm90b2NvbEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `64.91% <50.00%> (-0.55%)` | :arrow_down: |
| [...tor/format/facade/MySQLFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9mYWNhZGUvTXlTUUxGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...tor/format/facade/SQL92FormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL2Zvcm1hdC9mYWNhZGUvU1FMOTJGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...or/format/facade/OracleFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9PcmFjbGVGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...format/facade/OpenGaussFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3BlbmdhdXNzL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9PcGVuR2F1c3NGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...format/facade/SQLServerFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9TUUxTZXJ2ZXJGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...ormat/facade/PostgreSQLFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9mb3JtYXQvZmFjYWRlL1Bvc3RncmVTUUxGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
| [...ne/spi/rulealtered/RuleAlteredDetectorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvc3BpL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkRGV0ZWN0b3JGYWN0b3J5LmphdmE=) | `60.00% <0.00%> (-6.67%)` | :arrow_down: |
| [...text/admin/DatabaseAdminBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0RhdGFiYXNlQWRtaW5CYWNrZW5kSGFuZGxlckZhY3RvcnkuamF2YQ==) | `60.00% <0.00%> (-4.71%)` | :arrow_down: |
| [.../DropShardingBindingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvRHJvcFNoYXJkaW5nQmluZGluZ1RhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `79.62% <0.00%> (-4.38%)` | :arrow_down: |
| ... and [139 more](https://codecov.io/gh/apache/shardingsphere/pull/17632/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [46c1d05...fbcb7af](https://codecov.io/gh/apache/shardingsphere/pull/17632?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org