You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:53:14 UTC

[GitHub] [doris] Kikyou1997 opened a new pull request, #13218: [fix](planner) Check by partition instead of bucket

Kikyou1997 opened a new pull request, #13218:
URL: https://github.com/apache/doris/pull/13218

   # Proposed changes
   
   Issue Number: noissue
   
   ## Problem summary
   
   Use partition type instead of bucket number to determine if a `AlterColumnStats` is valid
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Kikyou1997 commented on pull request #13218: [fix](planner) Check by partition instead of bucket

Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #13218:
URL: https://github.com/apache/doris/pull/13218#issuecomment-1272492142

   @morrySnow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow merged pull request #13218: [fix](statstics) Incorrectly using the number of buckets to determine whether the table is partitioned

Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #13218:
URL: https://github.com/apache/doris/pull/13218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow commented on a diff in pull request #13218: [fix](planner) Check by partition instead of bucket

Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #13218:
URL: https://github.com/apache/doris/pull/13218#discussion_r990777302


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsManager.java:
##########
@@ -86,12 +87,12 @@ public void alterTableStatistics(AlterTableStatsStmt stmt) throws AnalysisExcept
      * @throws AnalysisException if table, column or partition not exist
      */
     public void alterColumnStatistics(AlterColumnStatsStmt stmt) throws AnalysisException {
-        Table table = validateTableName(stmt.getTableName());
+        OlapTable table = (OlapTable) validateTableName(stmt.getTableName());

Review Comment:
   we should do instanceof and cast when we do partition check, since not only OlapTable has statistics 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org