You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (Created) (JIRA)" <ji...@apache.org> on 2012/03/05 13:35:57 UTC
[jira] [Created] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Move classes around so that there are no two packages with the same name in different modules
---------------------------------------------------------------------------------------------
Key: WICKET-4439
URL: https://issues.apache.org/jira/browse/WICKET-4439
Project: Wicket
Issue Type: Sub-task
Affects Versions: 6.0.0
Reporter: Martin Grigorov
Priority: Minor
Fix For: 6.0.0
There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4439.
-------------------------------------
Resolution: Fixed
Assignee: Martin Grigorov
The patch is applied in master.
Please create a new ticket under WICKET-4438 if there are more OSGi related issues.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223954#comment-13223954 ]
Andreas Pieber commented on WICKET-4439:
----------------------------------------
damned... because of some windows-line-endings git apply of WICKET-4439.patch fails terribly for me on master (with/without core.autocrlf and --reject to the apply option). Can you pls push the changes into a new branch directly in the wicket repo on e.g. github? Thank you very much.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223939#comment-13223939 ]
Andreas Pieber commented on WICKET-4439:
----------------------------------------
1) I'm still at evaluating WICKET-4439.patch checking if it works correctly to add the osgi manifest.
2) I've copied and attached the src from OsgiPackageAnalyserScript here granting the "Licsensed for inclusion in ASF works" just to make sure that there are no license conflicts
3) WICKET-4439-test.patch: I really like the approach; pretty cool work! Though one comment about line 207...
{code}
if (className.endsWith(".class"))
{code}
...is not completely correct. The osgi import/export statements only describe which packages are available for resource loading. Therefore, if we need to load any packages with other resources than java code we need to check for a file (vs directory) in general rather than for a .class file.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4439:
------------------------------------
Attachment: WICKET-4439-test.patch
Add test that will stop us introducing such problems in future.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Andreas Pieber (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated WICKET-4439:
-----------------------------------
Attachment: OsgiPackageAnalyserScript.java
The code snippet from https://gist.github.com/1977817 with the license to ASF for inclusion in ASF works
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224106#comment-13224106 ]
Andreas Pieber commented on WICKET-4439:
----------------------------------------
thank you very much for the branch
I think an explicit blacklist in the test is the better way to go; that way we really have to think if we want to exclude a package or not.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4439:
------------------------------------
Attachment: WICKET-4439.patch
A patch the moves only the colliding classes in o.a.w.core.{SAME_PACKAGE}.
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4439) Move classes around so that there
are no two packages with the same name in different modules
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224101#comment-13224101 ]
Martin Grigorov commented on WICKET-4439:
-----------------------------------------
Done. The changes are committed to branch sandbox/wicket4439.
About the "endsWith(.classes)" - I did it this way to ignore META-INF folders and the files inside because they exist in all modules. Should I blacklist just them ?
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-4439
> URL: https://issues.apache.org/jira/browse/WICKET-4439
> Project: Wicket
> Issue Type: Sub-task
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0
>
> Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira