You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2019/11/10 14:29:24 UTC

[GitHub] [cassandra] Maxwell-Guo commented on a change in pull request #381: CASSANDRA-13019 Ratelimited snapshots

Maxwell-Guo commented on a change in pull request #381: CASSANDRA-13019 Ratelimited snapshots
URL: https://github.com/apache/cassandra/pull/381#discussion_r344495223
 
 

 ##########
 File path: src/java/org/apache/cassandra/db/Keyspace.java
 ##########
 @@ -309,8 +311,11 @@ public boolean snapshotExists(String snapshotName)
      */
     public static void clearSnapshot(String snapshotName, String keyspace)
     {
+        RateLimiter snapshotRateLimiter = RateLimiter.create(DatabaseDescriptor.getSnapshotLinksPerSecond() == 0 ?
 
 Review comment:
   the local variable name can change from snapshotRateLimiter to clearSnapshotRateLimiter, though they share the same value but they are of different use. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org