svn commit: r1619815 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java

[al...@apache.org]

Author: alexparvulescu
Date: Fri Aug 22 14:13:10 2014
New Revision: 1619815

URL: http://svn.apache.org/r1619815
Log:
OAK-2039 SegmentNodeStore might not create a checkpoint
 - added warning logs when checkpoint creation fails

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java?rev=1619815&r1=1619814&r2=1619815&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java Fri Aug 22 14:13:10 2014
@@ -51,6 +51,8 @@ import org.apache.jackrabbit.oak.spi.sta
 import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
 import org.apache.jackrabbit.oak.spi.state.NodeState;
 import org.apache.jackrabbit.oak.spi.state.NodeStore;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * The top level class for the segment store.
@@ -60,6 +62,9 @@ import org.apache.jackrabbit.oak.spi.sta
  */
 public class SegmentNodeStore implements NodeStore, Observable {
 
+    private static final Logger log = LoggerFactory
+            .getLogger(SegmentNodeStore.class);
+
     static final String ROOT = "root";
 
     private final SegmentStore store;
@@ -235,6 +240,10 @@ public class SegmentNodeStore implements
                     if (store.setHead(state, newState)) {
                         refreshHead();
                         return name;
+                    } else {
+                        log.warn(
+                                "Unable to update the head state for checkpoint {} ({}/5)",
+                                new Object[] { name, i + 1 });
                     }
 
                 } finally {
@@ -243,6 +252,7 @@ public class SegmentNodeStore implements
             }
         }
 
+        log.warn("Failed to create checkpoint {}", name);
         return name;
     }