You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/20 04:05:12 UTC

[GitHub] [flink] kylemeow opened a new pull request, #21123: [hotfix][table] Fix misleading state cleared message in SinkUpsertMaterializer

kylemeow opened a new pull request, #21123:
URL: https://github.com/apache/flink/pull/21123

   ## What is the purpose of the change
   
   When non-deterministic functions (like `UUID()`) or some special metadata fields (like `op_type`) are used in the source or sink fields, the `SinkUpsertMaterializer` may fail to match the `-U` or `-D` record with existing states, making the delete or retract record being erroneously dropped.
   
   In this case, the error message in the log is misleading, as it only says it is the statel ttl that caused this issue, which is untrue as user may have not enabled state TTL at all.
   
   ## Brief change log
   
   Enrich the error message to tell users more potential reasons.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: (yes / no / don't know) no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tisonkun commented on pull request #21123: [hotfix][table] Fix misleading state cleared message in SinkUpsertMaterializer

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #21123:
URL: https://github.com/apache/flink/pull/21123#issuecomment-1345194372

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21123: [hotfix][table] Fix misleading state cleared message in SinkUpsertMaterializer

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21123:
URL: https://github.com/apache/flink/pull/21123#issuecomment-1284898979

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0ef270ef9b35f0c9555fa222e746088a6c876e45",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0ef270ef9b35f0c9555fa222e746088a6c876e45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ef270ef9b35f0c9555fa222e746088a6c876e45 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org