You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bhanu Vanteru (JIRA)" <ji...@apache.org> on 2010/03/03 23:44:27 UTC
[jira] Created: (CONFIGURATION-410) Include forceReload or refresh
method in AbstractFileConfiguration
Include forceReload or refresh method in AbstractFileConfiguration
-------------------------------------------------------------------
Key: CONFIGURATION-410
URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
Project: Commons Configuration
Issue Type: Improvement
Components: File reloading
Reporter: Bhanu Vanteru
Priority: Minor
Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Bhanu Vanteru (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842828#action_12842828 ]
Bhanu Vanteru commented on CONFIGURATION-410:
---------------------------------------------
Hi, Thanks for your opening comment. I have attached the patch. Please review.
This is my first contribution to a open source project, so i am not sure of any guidelines that i should follow.
Thanks and Regards,
Bhanu Vanteru.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CONFIGURATION-410) Include forceReload or refresh
method in AbstractFileConfiguration
Posted by "Bhanu Vanteru (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bhanu Vanteru updated CONFIGURATION-410:
----------------------------------------
Attachment: AbstractFileConfiguration.java
Patch to include forceReload method which ignores strategy.reloadingRequired() check and so will always reload the configuration.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862779#action_12862779 ]
Oliver Heger commented on CONFIGURATION-410:
--------------------------------------------
Are there any news on this one?
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844961#action_12844961 ]
Oliver Heger commented on CONFIGURATION-410:
--------------------------------------------
Thanks for your patch. I had a look and understand how the feature is implemented. Some comments below:
* At least in minor releases we have to keep backwards compatibility to avoid breaking existing code. So we must not change the signature of public or protected methods or reduce method visibility.
* Was there a special reason why in the catch(Exception) block the if-statement was dropped?
* Is there any chance that you can provide a JUnit test? We usually only add new features if a unit test exists. If not, I can write a test myself.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CONFIGURATION-410) Include forceReload or refresh
method in AbstractFileConfiguration
Posted by "Bhanu Vanteru (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bhanu Vanteru updated CONFIGURATION-410:
----------------------------------------
Attachment: AbstractFileConfiguration.diff
Patch file for AbstractFileConfiguration.
Also, i have just submitted the ICLA. Thanks for suggesting.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Ralph Goers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842925#action_12842925 ]
Ralph Goers commented on CONFIGURATION-410:
-------------------------------------------
Thanks for the code!
The best way to submit a patch is to do an "svn diff" and submit the result of that. However, I'm sure we can figure out what the differences are.
If you plan on submitting more patches please consider filing an ICLA according to http://www.apache.org/licenses/.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
> Attachments: AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842820#action_12842820 ]
Oliver Heger commented on CONFIGURATION-410:
--------------------------------------------
Sounds useful. A patch would be appreciated. Many thanks!
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Priority: Minor
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-410) Include forceReload or
refresh method in AbstractFileConfiguration
Posted by "Emmanuel Bourg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928057#action_12928057 ]
Emmanuel Bourg commented on CONFIGURATION-410:
----------------------------------------------
I just saw this change and I was thinking we could add a reload(boolean forceReload) method instead of refresh(), but an undocumented method with this signature has already been added. The semantic of the reload operations is getting quite complex :/
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Assignee: Oliver Heger
> Priority: Minor
> Fix For: 1.7
>
> Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CONFIGURATION-410) Include forceReload or refresh
method in AbstractFileConfiguration
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Heger resolved CONFIGURATION-410.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.7
A new refresh() method was added to AbstractFileConfiguration and AbstractHierarchicalFileConfiguration. The update was applied in revision 1029169.
> Include forceReload or refresh method in AbstractFileConfiguration
> -------------------------------------------------------------------
>
> Key: CONFIGURATION-410
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-410
> Project: Commons Configuration
> Issue Type: Improvement
> Components: File reloading
> Reporter: Bhanu Vanteru
> Assignee: Oliver Heger
> Priority: Minor
> Fix For: 1.7
>
> Attachments: AbstractFileConfiguration.diff, AbstractFileConfiguration.java
>
>
> Consider an enhancement to AbstractFileConfiguration, where in a new method called forceReload() or refresh(), which is similar to the existing reload() method, except that strategy.reloadingRequired() is ignored and so a clear() and load() always occur when this new method is called. I will upload changes to AbstractFileConfiguration with this new method in a bit, for your review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.