[GitHub] [arrow-datafusion] r4ntix commented on a diff in pull request #6374: Prepare for object_store 0.6 and arrow 41

["r4ntix (via GitHub)" <gi...@apache.org>]

r4ntix commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1215577966


##########
datafusion-cli/src/object_storage.rs:
##########
@@ -36,10 +42,29 @@ pub fn get_s3_object_store_builder(
         builder = builder
             .with_access_key_id(access_key_id)
             .with_secret_access_key(secret_access_key);
-    }
 
-    if let Some(session_token) = cmd.options.get("session_token") {
-        builder = builder.with_token(session_token);
+        if let Some(session_token) = cmd.options.get("session_token") {
+            builder = builder.with_token(session_token);
+        }
+    } else {
+        let config = aws_config::from_env().load().await;

Review Comment:
   > cc @r4ntix as I think you contributed some of the previous configuration code
   
   @alamb Thanks for the heads up, I think this is a great improvement. Thanks @tustvold  👏



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org