You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/14 01:56:27 UTC
[GitHub] [spark] asl3 opened a new pull request, #41991: [SPARK-44413] Clarify error for unsupported arg data type in assertDataFrameEqual
asl3 opened a new pull request, #41991:
URL: https://github.com/apache/spark/pull/41991
### What changes were proposed in this pull request?
This PR adds an error class, `INVALID_TYPE_DF_EQUALITY_ARG`, to clarify the error message for unsupported argument data types when calling `assertDataFrameEqual`.
### Why are the changes needed?
The fix helps clarify why an error is thrown and what is wrong when a user passes unsupported arg types into the `assertDataFrameEqual` util function.
### Does this PR introduce _any_ user-facing change?
Yes, the PR modifies error message seen by users.
### How was this patch tested?
Modified tests in `runtime/python/pyspark/sql/tests/test_utils.py` and `runtime/python/pyspark/sql/tests/connect/test_utils.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asl3 closed pull request #41991: [DO-NOT-MERGE] Clarify error for unsupported arg data type in assertDataFrameEqual
Posted by "asl3 (via GitHub)" <gi...@apache.org>.
asl3 closed pull request #41991: [DO-NOT-MERGE] Clarify error for unsupported arg data type in assertDataFrameEqual
URL: https://github.com/apache/spark/pull/41991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41991: [SPARK-44413][PYTHON] Clarify error for unsupported arg data type in assertDataFrameEqual
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41991:
URL: https://github.com/apache/spark/pull/41991#discussion_r1263287529
##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -25,6 +25,7 @@
)
from pyspark.testing.utils import assertDataFrameEqual
from pyspark.testing.sqlutils import ReusedSQLTestCase
+from pyspark.sql import Row
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org