You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Mahadev Konar <ma...@apache.org> on 2014/03/02 22:06:45 UTC

Review Request 18671: Restart all on HDFS fails (Ambari DB: mysql)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18671/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-4905
    https://issues.apache.org/jira/browse/AMBARI-4905


Repository: ambari


Description
-------

Restart all on HDFS fails (Ambari DB: mysql)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60688af 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c0994c2 

Diff: https://reviews.apache.org/r/18671/diff/


Testing
-------

mvn test 


Thanks,

Mahadev Konar

Re: Review Request 18671: Restart all on HDFS fails (Ambari DB: mysql)

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18671/#review35933
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/18671/#comment66744>

    We should have createHostAction() also call createDeefaultHostParams(). That way there is only one location to initialize these parameters.
    
    Can be opened as a separate issue to refactor the code.


- Sumit Mohanty


On March 2, 2014, 9:06 p.m., Mahadev Konar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18671/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 9:06 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-4905
>     https://issues.apache.org/jira/browse/AMBARI-4905
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Restart all on HDFS fails (Ambari DB: mysql)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60688af 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c0994c2 
> 
> Diff: https://reviews.apache.org/r/18671/diff/
> 
> 
> Testing
> -------
> 
> mvn test 
> 
> 
> Thanks,
> 
> Mahadev Konar
> 
>

Re: Review Request 18671: Restart all on HDFS fails (Ambari DB: mysql)

Posted by Sumit Mohanty <sm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18671/#review35934
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On March 2, 2014, 9:06 p.m., Mahadev Konar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18671/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 9:06 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-4905
>     https://issues.apache.org/jira/browse/AMBARI-4905
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Restart all on HDFS fails (Ambari DB: mysql)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60688af 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c0994c2 
> 
> Diff: https://reviews.apache.org/r/18671/diff/
> 
> 
> Testing
> -------
> 
> mvn test 
> 
> 
> Thanks,
> 
> Mahadev Konar
> 
>

Re: Review Request 18671: Restart all on HDFS fails (Ambari DB: mysql)

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18671/#review35944
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On March 2, 2014, 9:06 p.m., Mahadev Konar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18671/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 9:06 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-4905
>     https://issues.apache.org/jira/browse/AMBARI-4905
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Restart all on HDFS fails (Ambari DB: mysql)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60688af 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c0994c2 
> 
> Diff: https://reviews.apache.org/r/18671/diff/
> 
> 
> Testing
> -------
> 
> mvn test 
> 
> 
> Thanks,
> 
> Mahadev Konar
> 
>