You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org> on 2006/08/11 07:53:14 UTC
[jira] Created: (HARMONY-1150) [classlib][instrument]Harmony lacks
of default implementation for java.lang.instrument.Instrumentation
[classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
------------------------------------------------------------------------------------------------------
Key: HARMONY-1150
URL: http://issues.apache.org/jira/browse/HARMONY-1150
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Jimmy, Jing Lv
Hi,
The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1150) [classlib][instrument]Harmony lacks
of default implementation for java.lang.instrument.Instrumentation
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1150?page=all ]
Paulex Yang closed HARMONY-1150.
--------------------------------
Verified by Jimmy
> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1150
> URL: http://issues.apache.org/jira/browse/HARMONY-1150
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assigned To: Paulex Yang
> Attachments: instrument.zip
>
>
> Hi,
> The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1150) [classlib][instrument]Harmony lacks
of default implementation for java.lang.instrument.Instrumentation
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1150?page=all ]
Paulex Yang reassigned HARMONY-1150:
------------------------------------
Assignee: Paulex Yang
> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1150
> URL: http://issues.apache.org/jira/browse/HARMONY-1150
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assigned To: Paulex Yang
> Attachments: instrument.zip
>
>
> Hi,
> The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1150) [classlib][instrument]Harmony lacks
of default implementation for java.lang.instrument.Instrumentation
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1150?page=all ]
Paulex Yang resolved HARMONY-1150.
----------------------------------
Resolution: Fixed
Jimmy, patch applied at revision r430751, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
Though I found some potential issues of this patch, say, the error code definition is magic number, so if JVMTI change the error code value, the codes will break. And further, the executePremain method uses default encoding to parse the class name, I think it is dangerous. I'm expecting your further enhancement on this. thank you.
> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1150
> URL: http://issues.apache.org/jira/browse/HARMONY-1150
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assigned To: Paulex Yang
> Attachments: instrument.zip
>
>
> Hi,
> The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1150) [classlib][instrument]Harmony lacks
of default implementation for java.lang.instrument.Instrumentation
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1150?page=all ]
Jimmy, Jing Lv updated HARMONY-1150:
------------------------------------
Attachment: instrument.zip
Hi,
Would you please try my patch? Thanks!
Best Regards,
Jimmy
> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1150
> URL: http://issues.apache.org/jira/browse/HARMONY-1150
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Attachments: instrument.zip
>
>
> Hi,
> The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1150) [classlib][instrument]Harmony
lacks of default implementation for java.lang.instrument.Instrumentation
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1150?page=comments#action_12427792 ]
Jimmy, Jing Lv commented on HARMONY-1150:
-----------------------------------------
Hello Paulex,
The fix is fine. And this is a work around and I will improve in the near future.Thanks!
Best regards,
Jimmy
> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1150
> URL: http://issues.apache.org/jira/browse/HARMONY-1150
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assigned To: Paulex Yang
> Attachments: instrument.zip
>
>
> Hi,
> The default implementation for java.lang.instrument.Instrumentation should be added as internal class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira