You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/07 10:27:59 UTC

[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

rmannibucau commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-704845082


   Hi @jenrryyou ,
   
   the PR looks good but is it possible to add a test about this case (thinking out loud DefaultShaderTest can be a base and required to generate a fake jar with nested jar using TemporaryFolder as base).
   
   Impl side note: a PushbackInputStream can probably avoid a custom inputstream impl and still enable to test the zip header.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org