You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2015/02/13 20:32:13 UTC

Review Request 31018: SENTRY-651: Add policy engine for lily hbase indexer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31018/
-----------------------------------------------------------

Review request for sentry, shen guoquan and Vamsee Yarlagadda.


Repository: sentry


Description
-------

Fairly straightforward translation from sentry-policy-search.

One naming fix in sentry-policy-search.


Diffs
-----

  pom.xml 8905862023f2ad0ab160d022f33c7a4e04e7fd3a 
  sentry-dist/pom.xml 67c6641a8c005b73ab93f34b8f681af327efc1e7 
  sentry-policy/pom.xml dfd3d8f35bdf2389f84352de4b119d6c8ffbf453 
  sentry-policy/sentry-policy-indexer/pom.xml PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/AbstractIndexerPrivilegeValidator.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerModelAuthorizables.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerRequiredInPrivilege.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/AbstractTestIndexerPolicyEngine.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/IndexerPolicyFileBackend.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderGeneralCases.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderSpecialCases.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerModelAuthorizables.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineDFS.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineLocalFS.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyNegative.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerRequiredInRole.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/resources/log4j.properties PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/resources/test-authz-provider.ini PRE-CREATION 
  sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchModelAuthorizables.java c2511cdaf259cd0617bfc581e24a92e7623b28d2 

Diff: https://reviews.apache.org/r/31018/diff/


Testing
-------

Ran the unit tests.


Thanks,

Gregory Chanan


Re: Review Request 31018: SENTRY-651: Add policy engine for lily hbase indexer

Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31018/#review72976
-----------------------------------------------------------



sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchModelAuthorizables.java
<https://reviews.apache.org/r/31018/#comment119102>

    Is this an intentional change? I mean looks like this is related to Search and we included it in the lily hbase support jira.
    Do we want to create a separate patch for this? Or is it okay to commit as part of this patch?


- Vamsee Yarlagadda


On Feb. 13, 2015, 7:32 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31018/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 7:32 p.m.)
> 
> 
> Review request for sentry, shen guoquan and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Fairly straightforward translation from sentry-policy-search.
> 
> One naming fix in sentry-policy-search.
> 
> 
> Diffs
> -----
> 
>   pom.xml 8905862023f2ad0ab160d022f33c7a4e04e7fd3a 
>   sentry-dist/pom.xml 67c6641a8c005b73ab93f34b8f681af327efc1e7 
>   sentry-policy/pom.xml dfd3d8f35bdf2389f84352de4b119d6c8ffbf453 
>   sentry-policy/sentry-policy-indexer/pom.xml PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/AbstractIndexerPrivilegeValidator.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerModelAuthorizables.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerRequiredInPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/AbstractTestIndexerPolicyEngine.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/IndexerPolicyFileBackend.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderGeneralCases.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderSpecialCases.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerModelAuthorizables.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineDFS.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineLocalFS.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyNegative.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerRequiredInRole.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/resources/log4j.properties PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/resources/test-authz-provider.ini PRE-CREATION 
>   sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchModelAuthorizables.java c2511cdaf259cd0617bfc581e24a92e7623b28d2 
> 
> Diff: https://reviews.apache.org/r/31018/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>


Re: Review Request 31018: SENTRY-651: Add policy engine for lily hbase indexer

Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31018/#review72979
-----------------------------------------------------------

Ship it!


I see you left a note in the description regarding the name change in search policy.

- Vamsee Yarlagadda


On Feb. 13, 2015, 7:32 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31018/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 7:32 p.m.)
> 
> 
> Review request for sentry, shen guoquan and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Fairly straightforward translation from sentry-policy-search.
> 
> One naming fix in sentry-policy-search.
> 
> 
> Diffs
> -----
> 
>   pom.xml 8905862023f2ad0ab160d022f33c7a4e04e7fd3a 
>   sentry-dist/pom.xml 67c6641a8c005b73ab93f34b8f681af327efc1e7 
>   sentry-policy/pom.xml dfd3d8f35bdf2389f84352de4b119d6c8ffbf453 
>   sentry-policy/sentry-policy-indexer/pom.xml PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/AbstractIndexerPrivilegeValidator.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerModelAuthorizables.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerRequiredInPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/AbstractTestIndexerPolicyEngine.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/IndexerPolicyFileBackend.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderGeneralCases.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderSpecialCases.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerModelAuthorizables.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineDFS.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyEngineLocalFS.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerPolicyNegative.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerRequiredInRole.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/resources/log4j.properties PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/resources/test-authz-provider.ini PRE-CREATION 
>   sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchModelAuthorizables.java c2511cdaf259cd0617bfc581e24a92e7623b28d2 
> 
> Diff: https://reviews.apache.org/r/31018/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>