[GitHub] dgrove-oss commented on a change in pull request #314: Switch from minikube to kubeadm-dind-cluster for TravisCI testing

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #314: Switch from minikube to kubeadm-dind-cluster for TravisCI testing
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/314#discussion_r225929015
 
 

 ##########
 File path: tools/travis/build-helm.sh
 ##########
 @@ -56,14 +56,15 @@ statefulsetHealthCheck () {
       break
     fi
 
-    kubectl get pods --all-namespaces -o wide --show-all
+    kubectl get pods -n openwhisk -o wide
 
     let TIMEOUT=TIMEOUT+1
     sleep 10
   done
 
-  if [ ! $PASSED ]; then
+  if [ "$PASSED" == "false" ]; then
     echo "Failed to finish deploying $1"
+    kubectl get pods --all-namespaces -o wide
 
 
 Review comment:
   No.  If something goes wrong I want to log the state of all the pods.  Sometimes the problem is a pod in the kube-system namespace is in a crash loop.  Added a comment to the script (here and in the other two places).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services