[GitHub] taegeonum commented on a change in pull request #128: [NEMO-235] Refactor TaskExecutor's data processing logic

[GitBox <gi...@apache.org>]

taegeonum commented on a change in pull request #128: [NEMO-235] Refactor TaskExecutor's data processing logic
URL: https://github.com/apache/incubator-nemo/pull/128#discussion_r228027423
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/TaskExecutor.java
 ##########
 @@ -634,11 +502,12 @@ private void finalizeOutputWriters(final VertexHarness vertexHarness) {
     });
 
     // finalize OutputWriters for additional tagged children
-    vertexHarness.getWritersToAdditionalChildrenTasks().values().forEach(outputWriter -> {
-      outputWriter.close();
-
-      final Optional<Long> writtenBytes = outputWriter.getWrittenBytes();
-      writtenBytes.ifPresent(writtenBytesList::add);
+    vertexHarness.getWritersToAdditionalChildrenTasks().values().forEach(outputWriters -> {
+      outputWriters.forEach(outputWriter -> {
 
 Review comment:
   Good point! I'd like to change, but then the OutputCollector should contain `metricSender`, and I don't want to send the metrics within the `OutputCollector`. It requires some refactoring of metric sending, so I want to do it in a separate issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services