You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/06/30 14:58:01 UTC

[4/4] hbase git commit: HBASE-18293 Only add the spotbugs dependency when jdk8 is active

HBASE-18293 Only add the spotbugs dependency when jdk8 is active

Signed-off-by: Sean Busbey <bu...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8c37b912
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8c37b912
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8c37b912

Branch: refs/heads/branch-2
Commit: 8c37b912acc6f4c80e0d71fadbc14d64a31d067f
Parents: 8005d32
Author: Chia-Ping Tsai <ch...@gmail.com>
Authored: Thu Jun 29 13:16:40 2017 +0800
Committer: Sean Busbey <bu...@apache.org>
Committed: Fri Jun 30 09:52:26 2017 -0500

----------------------------------------------------------------------
 pom.xml | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/8c37b912/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index a11a945..ea20401 100644
--- a/pom.xml
+++ b/pom.xml
@@ -655,13 +655,6 @@
             <xmlOutput>true</xmlOutput>
             <effort>Max</effort>
           </configuration>
-          <dependencies>
-            <dependency>
-              <groupId>com.github.spotbugs</groupId>
-              <artifactId>spotbugs</artifactId>
-              <version>${spotbugs.version}</version>
-            </dependency>
-          </dependencies>
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
@@ -2067,6 +2060,25 @@
                 <additionalparam>-Xdoclint:none</additionalparam>
               </configuration>
             </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>findbugs-maven-plugin</artifactId>
+              <version>3.0.0</version>
+              <!--NOTE: Findbugs 3.0.0 requires jdk7-->
+              <configuration>
+                <excludeFilterFile>${project.basedir}/../dev-support/findbugs-exclude.xml</excludeFilterFile>
+                <findbugsXmlOutput>true</findbugsXmlOutput>
+                <xmlOutput>true</xmlOutput>
+                <effort>Max</effort>
+              </configuration>
+              <dependencies>
+                <dependency>
+                  <groupId>com.github.spotbugs</groupId>
+                  <artifactId>spotbugs</artifactId>
+                  <version>${spotbugs.version}</version>
+                </dependency>
+              </dependencies>
+            </plugin>
           </plugins>
         </pluginManagement>
       </build>