You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2014/06/11 03:49:21 UTC
svn commit: r1601796 - in /tomcat/trunk:
java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml
Author: violetagg
Date: Wed Jun 11 01:49:21 2014
New Revision: 1601796
URL: http://svn.apache.org/r1601796
Log:
Provide a better error message when asynchronous operations are not supported by a filter or servlet. Patch provided by Romain Manni-Bucau. Issue was reported via users at tomcat.a.o.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1601796&r1=1601795&r2=1601796&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Wed Jun 11 01:49:21 2014
@@ -1601,7 +1601,8 @@ public class Request
public AsyncContext startAsync(ServletRequest request,
ServletResponse response) {
if (!isAsyncSupported()) {
- throw new IllegalStateException("Not supported.");
+ throw new IllegalStateException(
+ "A filter or servlet of the current chain does not support asynchronous operations.");
}
if (asyncContext == null) {
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1601796&r1=1601795&r2=1601796&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jun 11 01:49:21 2014
@@ -130,6 +130,11 @@
<bug>56600</bug>: In WebdavServlet: Do not waste time generating
response for broken PROPFIND request. (kkolinko)
</fix>
+ <fix>
+ Provide a better error message when asynchronous operations are not
+ supported by a filter or servlet. Patch provided by Romain Manni-Bucau.
+ (violetagg)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1601796 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java
webapps/docs/changelog.xml
Posted by Violeta Georgieva <mi...@gmail.com>.
2014-06-11 13:27 GMT+03:00 Mark Thomas <ma...@apache.org>:
>
> On 11/06/2014 02:49, violetagg@apache.org wrote:
> > Author: violetagg
> > Date: Wed Jun 11 01:49:21 2014
> > New Revision: 1601796
> >
> > URL: http://svn.apache.org/r1601796
> > Log:
> > Provide a better error message when asynchronous operations are not
supported by a filter or servlet. Patch provided by Romain Manni-Bucau.
Issue was reported via users at tomcat.a.o.
> >
> > Modified:
> > tomcat/trunk/java/org/apache/catalina/connector/Request.java
> > tomcat/trunk/webapps/docs/changelog.xml
> >
> > Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1601796&r1=1601795&r2=1601796&view=diff
> >
==============================================================================
> > --- tomcat/trunk/java/org/apache/catalina/connector/Request.java
(original)
> > +++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Wed
Jun 11 01:49:21 2014
> > @@ -1601,7 +1601,8 @@ public class Request
> > public AsyncContext startAsync(ServletRequest request,
> > ServletResponse response) {
> > if (!isAsyncSupported()) {
> > - throw new IllegalStateException("Not supported.");
> > + throw new IllegalStateException(
> > + "A filter or servlet of the current chain does not
support asynchronous operations.");
> > }
> >
> > if (asyncContext == null) {
>
> i18n? There is a StringManager available.
Fixed
Thanks
>
> Mark
>
>
> >
> > Modified: tomcat/trunk/webapps/docs/changelog.xml
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1601796&r1=1601795&r2=1601796&view=diff
> >
==============================================================================
> > --- tomcat/trunk/webapps/docs/changelog.xml (original)
> > +++ tomcat/trunk/webapps/docs/changelog.xml Wed Jun 11 01:49:21 2014
> > @@ -130,6 +130,11 @@
> > <bug>56600</bug>: In WebdavServlet: Do not waste time
generating
> > response for broken PROPFIND request. (kkolinko)
> > </fix>
> > + <fix>
> > + Provide a better error message when asynchronous operations
are not
> > + supported by a filter or servlet. Patch provided by Romain
Manni-Bucau.
> > + (violetagg)
> > + </fix>
> > </changelog>
> > </subsection>
> > <subsection name="Coyote">
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: svn commit: r1601796 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java
webapps/docs/changelog.xml
Posted by Mark Thomas <ma...@apache.org>.
On 11/06/2014 02:49, violetagg@apache.org wrote:
> Author: violetagg
> Date: Wed Jun 11 01:49:21 2014
> New Revision: 1601796
>
> URL: http://svn.apache.org/r1601796
> Log:
> Provide a better error message when asynchronous operations are not supported by a filter or servlet. Patch provided by Romain Manni-Bucau. Issue was reported via users at tomcat.a.o.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/Request.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1601796&r1=1601795&r2=1601796&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Wed Jun 11 01:49:21 2014
> @@ -1601,7 +1601,8 @@ public class Request
> public AsyncContext startAsync(ServletRequest request,
> ServletResponse response) {
> if (!isAsyncSupported()) {
> - throw new IllegalStateException("Not supported.");
> + throw new IllegalStateException(
> + "A filter or servlet of the current chain does not support asynchronous operations.");
> }
>
> if (asyncContext == null) {
i18n? There is a StringManager available.
Mark
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1601796&r1=1601795&r2=1601796&view=diff
> ==============================================================================
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Wed Jun 11 01:49:21 2014
> @@ -130,6 +130,11 @@
> <bug>56600</bug>: In WebdavServlet: Do not waste time generating
> response for broken PROPFIND request. (kkolinko)
> </fix>
> + <fix>
> + Provide a better error message when asynchronous operations are not
> + supported by a filter or servlet. Patch provided by Romain Manni-Bucau.
> + (violetagg)
> + </fix>
> </changelog>
> </subsection>
> <subsection name="Coyote">
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org