You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "lsq27 (via GitHub)" <gi...@apache.org> on 2023/08/16 14:58:28 UTC

[GitHub] [skywalking-java] lsq27 commented on pull request #594: Add Spring Runner plugin

lsq27 commented on PR #594:
URL: https://github.com/apache/skywalking-java/pull/594#issuecomment-1680778028

   > I don't really see what's the point to trace the runner, Spring runners are usually one-off tasks. Can you share why we want to trace them?
   
   The feature was inspired by the [spring-scheduled-annotation-plugin](https://github.com/apache/skywalking-java/tree/main/apm-sniffer/apm-sdk-plugin/spring-plugins/scheduled-annotation-plugin). Spring runner can be considered a special scheduled task triggered only once after the SpringApplication has started.
   
   Asuming that an application needs access several services via HTTP or RPC in Spring runners, spans can be integrated in one segment with this plugin, otherwise each span will be in different segments. This plugin can show which class send the requests like `spring-scheduled-annotation-plugin` does.
   
   The feature can be used to improve the tracing of Spring Boot. Since this feature does only a samll thing at the beginning of application, whether the feature should be made a stand alone plugin or a part of so-called spring-boot-plugin in which the code about Spring Boot can be put?
   
   before
   
   ![image](https://github.com/apache/skywalking-java/assets/22345692/1a27849d-7a36-43a2-a66e-d2ad82e0cbdb)
   
   after
   
   ![image](https://github.com/apache/skywalking-java/assets/22345692/071416c6-f579-469d-823a-88e90fd2ed1c)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org