You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/21 03:41:48 UTC

[GitHub] [apisix-ingress-controller] Donghui0 opened a new issue #476: request help: ingress event translate route is problematic

Donghui0 opened a new issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476


   ### Issue description
       ingress PathType column  on Kubernetes 1.18+ support.   After the translate, the routes can only match exactly. 
       I expected  /    ->   /*     translate result.
   
       only remove this judgment from the code ?
   
       `if pathRule.PathType != nil && *pathRule.PathType == extensionsv1beta1.PathTypePrefix`
   
   
   
   ### Environment
   
   * your apisix-ingress-controller version: 0.6
   * your Kubernetes cluster version: 1.16
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-845637372


   > @Donghui0 I think we cannot remove this for users using ingress in the extensions group on Kubernetes 1.18+.
   > 
   > Does `/*` at `path` work for you?
   
   We are migrating traefik in the test environment to apisix ingress controller.   If i modify the / of path to /*, it is not sure whether traefik can be compatible.  I can try it .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] Donghui0 closed issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
Donghui0 closed issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers removed a comment on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
tokers removed a comment on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-845634852


   @Donghui0 See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#httpingresspath-v1beta1-extensions
   
   `PathType` is a valid field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-845634852


   @Donghui0 See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#httpingresspath-v1beta1-extensions
   
   `PathType` is a valid field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] gxthrj commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-845683047


   In traefik use `Path` and `PathPrefix` rule for the route match, which can be used to decide how to set Paths in ApisixRoute resource.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-851399913


   > @Donghui0 Any new updates?
   
   no problem.   
   I temporarily modified part of this code. this feature may not be used by most people, so won’t submit a pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-851103867


   @Donghui0 Any new updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers commented on issue #476: request help: ingress event translate route is problematic

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #476:
URL: https://github.com/apache/apisix-ingress-controller/issues/476#issuecomment-845635687


   @Donghui0 I think we cannot remove this for users using ingress in the extensions group on Kubernetes 1.18+.
   
   Does `/*` at `path` work for you? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org