You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/07/26 07:32:46 UTC

[GitHub] [incubator-ratis] cyrus-jackson opened a new pull request #156: Ratis 956 - Use format specifier instead of string concat

cyrus-jackson opened a new pull request #156:
URL: https://github.com/apache/incubator-ratis/pull/156


   ## What changes were proposed in this pull request?
   This PR aims to remove code smell in the log messages by using formatter. 
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/projects/RATIS/issues/RATIS-956
   
   ## How was this patch tested?
   
   Existing Unit Tests. As this PR only changes log formatter. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #156: Ratis 956 - Use format specifier instead of string concat

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #156:
URL: https://github.com/apache/incubator-ratis/pull/156#issuecomment-666771200


   +1 this is really nice!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #156: Ratis 956 - Use format specifier instead of string concat

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #156:
URL: https://github.com/apache/incubator-ratis/pull/156#issuecomment-722160402


   @cyrus-jackson Could you help resolve the conflicts ? I will review and merge this patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org