[jira] [Commented] (KAFKA-5511) ConfigDef.define() overloads take too many parameters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781131#comment-16781131 ] 

ASF GitHub Bot commented on KAFKA-5511:
---------------------------------------

pierDipi commented on pull request #6348: KAFKA-5511 ConfigKeyBuilder for ConfigDef
URL: https://github.com/apache/kafka/pull/6348
 
 
   This patch add ConfigKeyBuilder in order to improve readability in the future configuration definitions and avoid some parameters order related bug.
   
   Using the builder inside the all arguments `define` method we can reuse all previous written tests, which cover all the changes.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConfigDef.define() overloads take too many parameters
> -----------------------------------------------------
>
>                 Key: KAFKA-5511
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5511
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Evgeny Veretennikov
>            Priority: Minor
>
> Builder pattern can be helpful to get rid of all these {{define()}} overloads. I think, it's better to create some {{ConfigKeyBuilder}} class to construct keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)