You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Xiaoqiao He (Jira)" <ji...@apache.org> on 2023/05/21 11:12:00 UTC
[jira] [Assigned] (HDFS-16909) Make judging null statment out from for loop in ReplicaMap#mergeAll method.
[ https://issues.apache.org/jira/browse/HDFS-16909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiaoqiao He reassigned HDFS-16909:
----------------------------------
Assignee: farmmamba
> Make judging null statment out from for loop in ReplicaMap#mergeAll method.
> ---------------------------------------------------------------------------
>
> Key: HDFS-16909
> URL: https://issues.apache.org/jira/browse/HDFS-16909
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.4
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> Currently, the code is as below:
> {code:java}
> for (ReplicaInfo replicaInfo : replicaSet) {
> checkBlock(replicaInfo);
> if (curSet == null) {
> // Add an entry for block pool if it does not exist already
> curSet = new LightWeightResizableGSet<>();
> map.put(bp, curSet);
> }
> curSet.put(replicaInfo);
> } {code}
> the statment :
> {code:java}
> if(curSet == null){code}
> should be moved to outside from the for loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org